Skip to content

fix: sequential focus navigation starting point regression and hash routing #13884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 13, 2025
Merged

fix: sequential focus navigation starting point regression and hash routing #13884

merged 6 commits into from
Jun 13, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Jun 12, 2025 •
edited
Loading

fixes #13883 and sequential focus navigation in hash routing apps.

This PR ensures our sequential focus navigation setting works in hash routing apps by avoiding client-side navigation when using location.replace() to set the focus. It also moves the existing logic to obtain the URL hash (based on the routing mode) to its own function and limits the number of times we split the URL string to up to three parts (as Dominik put it, https://example.com/#<apphash>#<otherhash>, so if there are more # characters in <otherhash>, they won't go missing)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@eltigerchino eltigerchino mentioned this pull request Jun 12, 2025
Closed
6 tasks
elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nit

@benmccann @elliott-with-the-longest-name-on-github
Update packages/kit/src/runtime/client/client.js
70fb07f 
Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com>
benmccann
benmccann reviewed Jun 12, 2025
View reviewed changes
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: da5371c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino merged commit f86f33b into main Jun 13, 2025
18 checks passed
@eltigerchino eltigerchino deleted the fix-reset-focus branch June 13, 2025 02:12
@github-actions github-actions bot mentioned this pull request Jun 13, 2025
Merged
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Jun 14, 2025
@sidharthv96
Merge branch 'main' into sidv/styleText
d10dda9 
* main: (533 commits)
  Version Packages (sveltejs#13885)
  fix: sequential focus navigation starting point regression and hash routing (sveltejs#13884)
  feat: Respect abort signals during serverside fetch optimization (sveltejs#13877)
  fix: correct link to locals (sveltejs#13870)
  chore(deps): update pnpm to v10.12.1 (sveltejs#13876)
  chore: update Vitest to 3.2.3 (sveltejs#13865)
  Version Packages (sveltejs#13872)
  fix: correctly access `app.decoders` in inline and single output apps (sveltejs#13871)
  chore(deps): update dependency @netlify/functions to v4 (sveltejs#13838)
  Version Packages (sveltejs#13854)
  chore(deps): update pnpm to v10.12.1 (sveltejs#13849)
  fix: avoid setting sequential focus navigation starting point when using hash router (sveltejs#13861)
  fix: hash link to new page focuses the correct element (sveltejs#10856)
  fix: ensure `redirect` used in packages uses the same `Redirect` instance (sveltejs#13843)
  fix: include components dynamically imported in the universal load function when inlining CSS (sveltejs#13723)
  fix: correctly invalidate static analysis cache of child nodes during dev (sveltejs#13793)
  fix: suppress console spam for chrome devtools requests (sveltejs#13830)
  fix: correctly deserialize on the server (sveltejs#13686)
  fix: handle non-semver-style dependency versions (sveltejs#13850)
  Attempt to clarify use:enhance docs (sveltejs#13819)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reset_focus crashes on invalid CSS selectors in URL hash
3 participants
@eltigerchino @benmccann @elliott-with-the-longest-name-on-github