Skip to content

feat: Respect abort signals during serverside fetch optimization #13877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 12, 2025
Merged

feat: Respect abort signals during serverside fetch optimization #13877

merged 5 commits into from
Jun 12, 2025

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github commented Jun 10, 2025 •
edited
Loading

edit: I realized my smooth brain created a bunch of camelcase variables, will fix tomorrow

Closes #13874

I'm unsure whether this is the best way to do this... but I think it is? If there's an abort signal attached to our request and we bypass native HTTP fetch (for a same-origin direct-call optimization), we race the abort with the response.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d169997

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-kit-13877-svelte.vercel.app/

dummdidumm
dummdidumm approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good apart from nitty gritty detail

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github merged commit 211e78c into main Jun 12, 2025
18 checks passed
@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github deleted the elliott/respect-abort-signals branch June 12, 2025 14:05
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Jun 14, 2025
@sidharthv96
Merge branch 'main' into sidv/styleText
d10dda9 
* main: (533 commits)
  Version Packages (sveltejs#13885)
  fix: sequential focus navigation starting point regression and hash routing (sveltejs#13884)
  feat: Respect abort signals during serverside fetch optimization (sveltejs#13877)
  fix: correct link to locals (sveltejs#13870)
  chore(deps): update pnpm to v10.12.1 (sveltejs#13876)
  chore: update Vitest to 3.2.3 (sveltejs#13865)
  Version Packages (sveltejs#13872)
  fix: correctly access `app.decoders` in inline and single output apps (sveltejs#13871)
  chore(deps): update dependency @netlify/functions to v4 (sveltejs#13838)
  Version Packages (sveltejs#13854)
  chore(deps): update pnpm to v10.12.1 (sveltejs#13849)
  fix: avoid setting sequential focus navigation starting point when using hash router (sveltejs#13861)
  fix: hash link to new page focuses the correct element (sveltejs#10856)
  fix: ensure `redirect` used in packages uses the same `Redirect` instance (sveltejs#13843)
  fix: include components dynamically imported in the universal load function when inlining CSS (sveltejs#13723)
  fix: correctly invalidate static analysis cache of child nodes during dev (sveltejs#13793)
  fix: suppress console spam for chrome devtools requests (sveltejs#13830)
  fix: correctly deserialize on the server (sveltejs#13686)
  fix: handle non-semver-style dependency versions (sveltejs#13850)
  Attempt to clarify use:enhance docs (sveltejs#13819)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancelling fetch request to SvelteKit API route with AbortSignal: timeout() does not work
2 participants
@elliott-with-the-longest-name-on-github @dummdidumm