-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: handle non-semver-style dependency versions #13850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 13ff753 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense in the latest
or next
case, but a bit less in the workspace case described in #13553. Maybe we can check the value? If it's a workspace value it would be nice to resolve it or at least log that we're just making an assumption about what value to use whereas in the latest
or next
case you probably want to just silently proceed as is being done here
héhé, my PR is very close to this one! ^^ (with a warn already)
|
I don't think we need a warning - this is about checking for Svelte 3, which is rarely used these days. People using catalogs are certainly using a newer version of Svelte, too. |
Almost made it to the repo :p Thank you |
Fixes #13836
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.