Skip to content

chore: update Vitest to 3.2.3 #13865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025
Merged

chore: update Vitest to 3.2.3 #13865

merged 4 commits into from
Jun 10, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Jun 9, 2025

This PR performs a few maintenance tasks:

  • Updates Vitest to 3.2.1 so that we no longer get errors when running type checking on the enhanced-img package.
  • Downgrades pnpm to 10.11.1 to get rid of the false positive pnpm warnings
 WARN  Skip adding @playwright/test to the default catalog because it already exists as ^1.51.1. Please use `pnpm update` to update the catalogs.
 WARN  Skip adding @playwright/test to the default catalog because it already exists as ^1.51.1. Please use `pnpm update` to update the catalogs.
 WARN  Skip adding @playwright/test to the default catalog because it already exists as ^1.51.1. Please use `pnpm update` to update the catalogs.
 WARN  Skip adding @playwright/test to the default catalog because it already exists as ^1.51.1. Please use `pnpm update` to update the catalogs.

- Removes the skipLibCheck tsconfig option from adapter-netlify because the Netlify functions type issue has been resolved by netlify/functions#473 There's a new type issue in the latest version


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jun 9, 2025

⚠️ No Changeset found

Latest commit: 00ad27c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

@benmccann
Copy link
Member

There's a 3.2.3 out now. Also there's a merge conflict in the lock file

@eltigerchino
Copy link
Member Author

Thanks! I've resolve the merge conflicts and updated Vitest. I had to re-enable skipLibCheck for the Netlify adapter because the latest @netlify/functions version has type errors netlify/primitives#302

@benmccann benmccann changed the title chore: update Vitest to 3.2.1 chore: update Vitest to 3.2.3 Jun 10, 2025
@benmccann benmccann merged commit 6ba4917 into main Jun 10, 2025
18 checks passed
@benmccann benmccann deleted the fix-types branch June 10, 2025 13:05
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Jun 14, 2025
* main: (533 commits)
  Version Packages (sveltejs#13885)
  fix: sequential focus navigation starting point regression and hash routing (sveltejs#13884)
  feat: Respect abort signals during serverside fetch optimization (sveltejs#13877)
  fix: correct link to locals (sveltejs#13870)
  chore(deps): update pnpm to v10.12.1 (sveltejs#13876)
  chore: update Vitest to 3.2.3 (sveltejs#13865)
  Version Packages (sveltejs#13872)
  fix: correctly access `app.decoders` in inline and single output apps (sveltejs#13871)
  chore(deps): update dependency @netlify/functions to v4 (sveltejs#13838)
  Version Packages (sveltejs#13854)
  chore(deps): update pnpm to v10.12.1 (sveltejs#13849)
  fix: avoid setting sequential focus navigation starting point when using hash router (sveltejs#13861)
  fix: hash link to new page focuses the correct element (sveltejs#10856)
  fix: ensure `redirect` used in packages uses the same `Redirect` instance (sveltejs#13843)
  fix: include components dynamically imported in the universal load function when inlining CSS (sveltejs#13723)
  fix: correctly invalidate static analysis cache of child nodes during dev (sveltejs#13793)
  fix: suppress console spam for chrome devtools requests (sveltejs#13830)
  fix: correctly deserialize on the server (sveltejs#13686)
  fix: handle non-semver-style dependency versions (sveltejs#13850)
  Attempt to clarify use:enhance docs (sveltejs#13819)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants