Skip to content

Merge main into main-v0.14.1 #8384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

einat-starkware
Copy link
Contributor

No description provided.

AvivYossef-starkware and others added 19 commits July 30, 2025 13:51
Co-authored-by: AvivYossef-starkware <141143145+AvivYossef-starkware@users.noreply.github.com>
…ed class hash v2 (#8292)

* apollo_central_sync,apollo_compile_to_casm: compute the actual compiled class hash v2

* starknet_api: use v2 hash in compiled class hash of contract class
Copy link

github-actions bot commented Aug 3, 2025

Artifacts upload workflows:

@reviewable-StarkWare
Copy link

This change is Reviewable

@einat-starkware einat-starkware requested a review from noaov1 August 3, 2025 10:58
Copy link

github-actions bot commented Aug 3, 2025

Benchmark movements: tree_computation_flow performance improved 😺 tree_computation_flow time: [34.178 ms 34.208 ms 34.244 ms] change: [-4.3550% -2.7899% -1.4161%] (p = 0.00 < 0.05) Performance has improved. Found 7 outliers among 100 measurements (7.00%) 1 (1.00%) low mild 2 (2.00%) high mild 4 (4.00%) high severe

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r1, 2 of 3 files at r2, 2 of 2 files at r4, 2 of 19 files at r5, 6 of 13 files at r6, 3 of 3 files at r7, 10 of 11 files at r9, 1 of 1 files at r10, 3 of 6 files at r11, 1 of 2 files at r12, 1 of 4 files at r13, 3 of 3 files at r14, 2 of 2 files at r15, 4 of 4 files at r16, 1 of 1 files at r17, 1 of 1 files at r18, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @einat-starkware)

@einat-starkware einat-starkware merged commit 6318307 into main-v0.14.1 Aug 3, 2025
31 of 34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2025
@einat-starkware einat-starkware deleted the einatg/merge-main-into-main-v0.14.1-1754217970 branch August 5, 2025 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants