-
Notifications
You must be signed in to change notification settings - Fork 58
starknet_committer: add alias for map storage #8316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)
crates/starknet_committer_and_os_cli/src/committer_cli/tests/regression_tests.rs
line 43 at r1 (raw file):
// TODO(Nimrod): Delete this struct and use `CommitterInputImpl` instead. struct CommitterInput(Input<ConfigImpl>, MapStorage);
you have a PR for this TODO as well?
Code quote:
// TODO(Nimrod): Delete this struct and use `CommitterInputImpl` instead.
struct CommitterInput(Input<ConfigImpl>, MapStorage);
crates/starknet_patricia_storage/src/map_storage.rs
line 7 at r1 (raw file):
use crate::storage_trait::{DbKey, DbValue, Storage}; pub type MapStorage = HashMap<DbKey, DbValue>; #[derive(Serialize, Debug)]
newlines around type / struct defs
Suggestion:
use crate::storage_trait::{DbKey, DbValue, Storage};
pub type MapStorage = HashMap<DbKey, DbValue>;
#[derive(Serialize, Debug)]
0fe3ade
to
bcf243c
Compare
2ad38aa
to
2c72839
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)
bcf243c
to
fe6a301
Compare
2c72839
to
07ed068
Compare
Benchmark movements: No major performance changes detected. |
07ed068
to
b403cc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 9 of 11 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)
crates/starknet_committer_and_os_cli/src/committer_cli/tests/regression_tests.rs
line 43 at r1 (raw file):
Previously, dorimedini-starkware wrote…
you have a PR for this TODO as well?
yes, on top of this:
https://reviewable.io/reviews/starkware-libs/sequencer/8322
crates/starknet_patricia_storage/src/map_storage.rs
line 7 at r1 (raw file):
Previously, dorimedini-starkware wrote…
newlines around type / struct defs
Done.
fe6a301
to
6173623
Compare
b403cc4
to
5b31389
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)
5b31389
to
51068bf
Compare
6173623
to
b9c6bf7
Compare
Merge activity
|
51068bf
to
3caab57
Compare
No description provided.