Skip to content

starknet_committer: add alias for map storage #8316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025

Conversation

nimrod-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

nimrod-starkware commented Jul 30, 2025

@nimrod-starkware nimrod-starkware self-assigned this Jul 30, 2025
@nimrod-starkware nimrod-starkware marked this pull request as ready for review July 30, 2025 11:45
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)


crates/starknet_committer_and_os_cli/src/committer_cli/tests/regression_tests.rs line 43 at r1 (raw file):

// TODO(Nimrod): Delete this struct and use `CommitterInputImpl` instead.
struct CommitterInput(Input<ConfigImpl>, MapStorage);

you have a PR for this TODO as well?

Code quote:

// TODO(Nimrod): Delete this struct and use `CommitterInputImpl` instead.
struct CommitterInput(Input<ConfigImpl>, MapStorage);

crates/starknet_patricia_storage/src/map_storage.rs line 7 at r1 (raw file):

use crate::storage_trait::{DbKey, DbValue, Storage};
pub type MapStorage = HashMap<DbKey, DbValue>;
#[derive(Serialize, Debug)]

newlines around type / struct defs

Suggestion:

use crate::storage_trait::{DbKey, DbValue, Storage};

pub type MapStorage = HashMap<DbKey, DbValue>;

#[derive(Serialize, Debug)]

@nimrod-starkware nimrod-starkware force-pushed the nimrod/rename_map_storage branch from 0fe3ade to bcf243c Compare July 30, 2025 13:17
@nimrod-starkware nimrod-starkware force-pushed the nimrod/map_storage_type branch from 2ad38aa to 2c72839 Compare July 30, 2025 13:17
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)

Copy link

Benchmark movements: No major performance changes detected.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/map_storage_type branch from 07ed068 to b403cc4 Compare July 30, 2025 14:51
Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 9 of 11 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)


crates/starknet_committer_and_os_cli/src/committer_cli/tests/regression_tests.rs line 43 at r1 (raw file):

Previously, dorimedini-starkware wrote…

you have a PR for this TODO as well?

yes, on top of this:
https://reviewable.io/reviews/starkware-libs/sequencer/8322


crates/starknet_patricia_storage/src/map_storage.rs line 7 at r1 (raw file):

Previously, dorimedini-starkware wrote…

newlines around type / struct defs

Done.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@graphite-app graphite-app bot changed the base branch from nimrod/rename_map_storage to graphite-base/8316 July 31, 2025 08:53
@nimrod-starkware nimrod-starkware force-pushed the nimrod/map_storage_type branch from 5b31389 to 51068bf Compare July 31, 2025 09:24
@graphite-app graphite-app bot changed the base branch from graphite-base/8316 to main July 31, 2025 09:25
Copy link

graphite-app bot commented Jul 31, 2025

Merge activity

  • Jul 31, 9:25 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/map_storage_type branch from 51068bf to 3caab57 Compare July 31, 2025 13:11
@nimrod-starkware nimrod-starkware added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit 90be14c Jul 31, 2025
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants