Skip to content

apollo_state_reader: get compiled class hash v2 #8296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review July 29, 2025 12:49
Copy link
Contributor Author

AvivYossef-starkware commented Jul 29, 2025

Copy link

github-actions bot commented Jul 29, 2025

Benchmark movements: No major performance changes detected.

Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_v2_hash_in_compiled_class_hash_of_a_contract_class branch from 4ecd317 to 211caff Compare July 30, 2025 08:22
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_compiled_class_hash_v2_from_papyrus branch from 4c41669 to 58b8b30 Compare July 30, 2025 08:25
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_v2_hash_in_compiled_class_hash_of_a_contract_class branch from 211caff to b6abc95 Compare July 30, 2025 08:35
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_compiled_class_hash_v2_from_papyrus branch from 58b8b30 to 277eafc Compare July 30, 2025 08:35
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_v2_hash_in_compiled_class_hash_of_a_contract_class branch from b6abc95 to c407ffa Compare July 30, 2025 11:31
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_compiled_class_hash_v2_from_papyrus branch from 277eafc to bcfada4 Compare July 30, 2025 11:31
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_v2_hash_in_compiled_class_hash_of_a_contract_class branch from c407ffa to 344dd05 Compare July 31, 2025 08:03
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_compiled_class_hash_v2_from_papyrus branch from bcfada4 to 4c9bb21 Compare July 31, 2025 08:03
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_compiled_class_hash_v2_from_papyrus branch from 4c9bb21 to cf63d66 Compare July 31, 2025 11:41
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/use_v2_hash_in_compiled_class_hash_of_a_contract_class to aviv/compute_the_actual_compiled_class_hash_v2_during_compilation_and_sync July 31, 2025 11:41
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/compute_the_actual_compiled_class_hash_v2_during_compilation_and_sync branch from d6995e6 to a98d598 Compare July 31, 2025 13:39
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_compiled_class_hash_v2_from_papyrus branch from cf63d66 to fc4d9db Compare July 31, 2025 13:40
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/compute_the_actual_compiled_class_hash_v2_during_compilation_and_sync to graphite-base/8296 August 3, 2025 08:31
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_compiled_class_hash_v2_from_papyrus branch from fc4d9db to e6fd122 Compare August 3, 2025 08:31
@AvivYossef-starkware AvivYossef-starkware changed the base branch from graphite-base/8296 to main August 3, 2025 08:31
@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Aug 3, 2025
Merged via the queue into main with commit 1238987 Aug 3, 2025
16 of 28 checks passed
einat-starkware added a commit that referenced this pull request Aug 3, 2025
* starknet_os: use newer blake hash function (#8321)

* starknet_api: fix bug in compiled class hash (#8314)

* apollo_compile_to_casm: use the new compiled class hash function (#8282)

* blockifier: estimate migration - connect bouncer and estimation logic (#8231)

* starknet_committer: input doesn't take ownership of the storage (#8291)

* starknet_committer: rename map storage (#8315)

* starknet_os: use newer blake hash function (#8321) (#8323)

Co-authored-by: AvivYossef-starkware <141143145+AvivYossef-starkware@users.noreply.github.com>

* apollo_test_utils: fix casm test instance (#8340)

* starknet_committer: add alias for map storage (#8316)

* starknet_committer: delete duplicated definitions (#8322)

* starknet_os_flow_tests: define crate (#8341)

* starknet_os_flow_tests: execute txs (#8342)

* starknet_os_flow_tests: create state diff for the committer (#8343)

* starknet_os_flow_tests: commit state diff (#8344)

* apollo_gateway: refactor validate compiled class hash error message (#8356)

* apollo_central_sync,apollo_compile_to_casm: compute the actual compiled class hash v2 (#8292)

* apollo_central_sync,apollo_compile_to_casm: compute the actual compiled class hash v2

* starknet_api: use v2 hash in compiled class hash of contract class

* apollo_state_reader: get compiled class hash v2 (#8296)

* Merge remote-tracking branch 'origin/main' into einatg/merge-main-into-main-v0.14.1-1754217970

* No conflicts in main -> main-v0.14.1 merge, this commit is for any change needed to pass the CI.

Co-Authored-By: AvivYossef-starkware <141143145+AvivYossef-starkware@users.noreply.github.com>
Co-Authored-By: avivg-starkware <aviv.g@starkware.co>
Co-Authored-By: nimrod-starkware <143319383+nimrod-starkware@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants