starknet_os_flow_tests: commit state diff

[nimrod-starkware]

No description provided.

[nimrod-starkware]

• starknet_os_flow_tests: refactor creation of declare txs #8470
• starknet_os_flow_tests: decalre and deploy test contract as example #8460
• starknet_os_flow_tests: unit tests for division #8451
• starknet_os_flow_tests: flow test body #8397
• starknet_os_flow_tests: create cached state inputs and commitment infos #8396
• starknet_patricia: get previous leaves with default config #8445
• starknet_os_flow_tests: filter inner nodes for commitment info #8395
• starknet_os_flow_tests: create default initial state #8394
• starknet_os_flow_tests: implement state trait on dict state reader #8393
• starknet_os_flow_tests: define test manager #8363
• starknet_os_flow_tests: define intial test state #8345
• starknet_os_flow_tests: commit state diff #8344 👈 (View in Graphite)
• starknet_os_flow_tests: create state diff for the committer #8343
• starknet_os_flow_tests: execute txs #8342
• starknet_os_flow_tests: define crate #8341
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-07-31T08:14:39Z
• Started at 2025-07-31T08:24:15Z
• Started at 2025-07-31T08:50:10Z
• Started at 2025-07-31T13:41:27Z
• Started at 2025-07-31T13:41:27Z
• Started at 2025-07-31T14:02:29Z
• Started at 2025-07-31T14:29:39Z
• Started at 2025-07-31T19:40:52Z
• Started at 2025-08-02T07:21:01Z
• Started at 2025-08-02T07:21:31Z

[github-actions]

Benchmark movements: No major performance changes detected.

[dorimedini-starkware]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

---

crates/starknet_os_flow_tests/src/utils.rs line 94 at r1 (raw file):

    classes_trie_root_hash: HashOutput,
    state_diff: StateDiff,
) -> (HashOutput, HashOutput) {

please make the return type a struct with named fields (so it's clear which root is for which tree)

Code quote:

) -> (HashOutput, HashOutput)

[dorimedini-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

[nimrod-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/starknet_os_flow_tests/src/utils.rs line 94 at r1 (raw file):

Previously, dorimedini-starkware wrote…

please make the return type a struct with named fields (so it's clear which root is for which tree)

Done.

[dorimedini-starkware]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

---

crates/starknet_os_flow_tests/src/utils.rs line 98 at r3 (raw file):

/// Commits the state diff, saves the new facts and returns the computed roots.
async fn commit_state_diff(
    facts: &mut BorrowedMapStorage<'_>,

Suggestion:

commitments: &mut BorrowedMapStorage<'_>

[nimrod-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/starknet_os_flow_tests/src/utils.rs line 98 at r3 (raw file):

/// Commits the state diff, saves the new facts and returns the computed roots.
async fn commit_state_diff(
    facts: &mut BorrowedMapStorage<'_>,

Done.

[dorimedini-starkware]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

[graphite-app]

Merge activity

• Aug 2, 7:21 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.