starknet_os_flow_tests: execute txs

[nimrod-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

• starknet_os_flow_tests: refactor creation of declare txs #8470
• starknet_os_flow_tests: decalre and deploy test contract as example #8460
• starknet_os_flow_tests: unit tests for division #8451
• starknet_os_flow_tests: flow test body #8397
• starknet_os_flow_tests: create cached state inputs and commitment infos #8396
• starknet_patricia: get previous leaves with default config #8445
• starknet_os_flow_tests: filter inner nodes for commitment info #8395
• starknet_os_flow_tests: create default initial state #8394
• starknet_os_flow_tests: implement state trait on dict state reader #8393
• starknet_os_flow_tests: define test manager #8363
• starknet_os_flow_tests: define intial test state #8345
• starknet_os_flow_tests: commit state diff #8344
• starknet_os_flow_tests: create state diff for the committer #8343
• starknet_os_flow_tests: execute txs #8342 👈 (View in Graphite)
• starknet_os_flow_tests: define crate #8341
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @nimrod-starkware)

---

crates/starknet_os_flow_tests/src/utils.rs line 17 at r1 (raw file):

pub(crate) type ExecutionOutput<S> =
    (Vec<TransactionExecutionOutput>, BlockExecutionSummary, CachedState<S>);

why not make this a struct? prefer named fields to tuple-types

Code quote:

pub(crate) type ExecutionOutput<S> =
    (Vec<TransactionExecutionOutput>, BlockExecutionSummary, CachedState<S>);

---

crates/starknet_os_flow_tests/src/utils.rs line 22 at r1 (raw file):

/// configuration.
pub(crate) fn execute_transactions<S: FlowTestState>(
    initial_state_reader: S,

this state is not just a reader (right?)

Suggestion:

initial_state: S,

---

crates/starknet_os_flow_tests/src/utils.rs line 25 at r1 (raw file):

    txs: &[Transaction],
    block_context: BlockContext,
) -> ExecutionOutput<S> {

when executing transactions you need full context, not just the "initial state", i.e. you will need a class manager for declares?
is this the final API?

Code quote:

pub(crate) fn execute_transactions<S: FlowTestState>(
    initial_state_reader: S,
    txs: &[Transaction],
    block_context: BlockContext,
) -> ExecutionOutput<S> {

[nimrod-starkware]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/starknet_os_flow_tests/src/utils.rs line 17 at r1 (raw file):

Previously, dorimedini-starkware wrote…

why not make this a struct? prefer named fields to tuple-types

Done.

---

crates/starknet_os_flow_tests/src/utils.rs line 22 at r1 (raw file):

Previously, dorimedini-starkware wrote…

this state is not just a reader (right?)

Done.

---

crates/starknet_os_flow_tests/src/utils.rs line 25 at r1 (raw file):

Previously, dorimedini-starkware wrote…

when executing transactions you need full context, not just the "initial state", i.e. you will need a class manager for declares?
is this the final API?

Can you please explain wdym?
The plan is that execute_transactions will be called by the TestManager when the user wants to execute the test.
The context is updated when the user adds transactions to the test.

[dorimedini-starkware]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)

---

crates/starknet_os_flow_tests/src/utils.rs line 22 at r1 (raw file):

Previously, nimrod-starkware wrote…

Done.

nope :)

---

crates/starknet_os_flow_tests/src/utils.rs line 25 at r1 (raw file):

Previously, nimrod-starkware wrote…

Can you please explain wdym?
The plan is that execute_transactions will be called by the TestManager when the user wants to execute the test.
The context is updated when the user adds transactions to the test.

execute_transactions will be a method of TestManager, and have access to self?

[nimrod-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/starknet_os_flow_tests/src/utils.rs line 22 at r1 (raw file):

Previously, dorimedini-starkware wrote…

nope :)

now done, sorry

---

crates/starknet_os_flow_tests/src/utils.rs line 25 at r1 (raw file):

Previously, dorimedini-starkware wrote…

execute_transactions will be a method of TestManager, and have access to self?

no, I don't think it needs access to context.
the context will be mutated when inserting the txs.

[dorimedini-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

[graphite-app]

Merge activity

• Jul 31, 7:18 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.