Revit receive first pass: reference geometry workflow (CNX-403) #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably the fourth time
maybe too drastic, we will see soon
* highlight works * use status.success on receive success * question comment
and adds todos
Grouping sandbox
* materials wip * Make it work receiving render materials * MaterialBaker mods, cleanup * Address the PR comments * Remove invalid chars from structured material names --------- Co-authored-by: oguzhankoral <oguzhankoral@gmail.com>
…rt-for-layer-render-materials Feat(revit): CNX-470 add support for layer render materials
…stances-blocks-local-to-global Feat(revit) CNX-442 handle instances blocks local to global
* purge materials and groups in Revit before update * cleaner linq * renamed _groupManager to _groupBaker
didimitrie
changed the title
# Conflicts: # Connectors/Revit/Speckle.Connectors.RevitShared/Bindings/RevitReceiveBinding.cs # Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Receive/RevitHostObjectBuilder.cs # Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Receive/TransactionManager.cs # Converters/Revit/Speckle.Converters.RevitShared/ToHost/Raw/RenderMaterialToHostConverter.cs # Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/BrepToHostTopLevelConverter.cs # Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/DirectShapeTopLevelConverterToHost.cs # Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/GridlineToHostTopLevelConverter.cs # Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/LevelToHostTopLevelConverter.cs # Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/ModelCurveToSpeckleTopLevelConverter.cs # Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/PointToHostTopLevelConverter.cs
* minor changes, logging, comments * typo
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #254 +/- ##
========================================
+ Coverage 7.38% 7.86% +0.48%
========================================
Files 243 235 -8
Lines 4767 4473 -294
Branches 564 523 -41
========================================
Hits 352 352
+ Misses 4400 4106 -294
Partials 15 15 ☔ View full report in Codecov by Sentry. |
oguzhankoral
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at revit receive, where everything becomes a nested by collection direct shape.
CNX-403: Revit Receive: Reference Geometry Workflow