feat(dui3): adds prototype grouping by collection

and adds todos

Connectors/Revit/Speckle.Connectors.RevitShared/HostApp/RevitGroupManager.cs

@@ -17,71 +17,64 @@ public RevitGroupManager(IRevitConversionContextStack contextStack, ITransaction
     _transactionManager = transactionManager;
   }
 
-  public void CreateGroups()
-  {
-    // build edge list of the element graph in the bakeobjects method
-    // pass the edge list to the GroupManager
-    // in the GroupManager CreateGroups method:
-    // 1. find leaf nodes
-    // 2. group leaf nodes by parent id
-    // 3. make revit groups from each leaf group
-    // 4. replace the parent id of the leaves with the new group id everywhere in the edge list
-    // 5. remove leaf edges
-    // 6. repeat the above until we have edges
-
-    return;
-  }
-
   // We cannot add objects to groups in revit, we need to create a group all at once with all its subkids
   // We need to create groups at the end of the day in a separate new transaction
   public void AddToGroupMapping(TraversalContext tc, DirectShape ds)
   {
     var collectionPath = GetLayerPath(tc);
     var currentLayerName = "Base Group";
-    var previousGroup = _baseGroup;
+    FakeGroup? previousGroup = null;
     var currentDepth = 0;
+
     foreach (var collection in collectionPath)
     {
       currentLayerName += "::" + collection.name;
       if (_groupCache.TryGetValue(currentLayerName, out FakeGroup g))
       {
         previousGroup = g;
+        currentDepth++;
         continue;
       }
 
       var group = new FakeGroup()
       {
-        Name = currentLayerName,
+        Name = collection.name, // TODO: Sanitize all names according to revit's liking
         Depth = currentDepth++,
-        Parent = previousGroup
+        Parent = previousGroup!
       };
       _groupCache[currentLayerName] = group;
       previousGroup = group;
     }
 
-    previousGroup.Ids.Add(ds.Id);
+    previousGroup!.Ids.Add(ds.Id);
   }
 
   private readonly Dictionary<string, FakeGroup> _groupCache = new();
 
-  public void BakeGroups()
+  public void BakeGroups(string baseGroupName)
   {
     var orderedGroups = _groupCache.Values.OrderByDescending(group => group.Depth);
+    Group? lastGroup = null;
+
     foreach (var group in orderedGroups)
     {
-      var docGroup = _contextStack.Current.Document.Create.NewGroup(group.Ids); // TODO
-      group.Parent.Ids.Add(docGroup.Id);
+      var docGroup = _contextStack.Current.Document.Create.NewGroup(group.Ids);
+      if (group.Parent != null)
+      {
+        group.Parent.Ids.Add(docGroup.Id);
+      }
+      docGroup.GroupType.Name = group.Name;
+      lastGroup = docGroup;
     }
-  }
 
-  private FakeGroup _baseGroup = new() { Name = "Base Group", Depth = 0 };
-}
+    lastGroup!.GroupType.Name = baseGroupName;
+  }
 
-sealed class FakeGroup
-{
-  public List<ElementId> Ids { get; set; } = new();
-  public int Depth { get; set; }
-  public string Name { get; set; }
-  public string HostId { get; set; } // will be used on baking, should be subsumed into ids
-  public FakeGroup Parent { get; set; }
+  private sealed class FakeGroup
+  {
+    public List<ElementId> Ids { get; set; } = new();
+    public int Depth { get; set; }
+    public string Name { get; set; }
+    public FakeGroup Parent { get; set; }
+  }
 }

Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Receive/RevitHostObjectBuilder.cs

@@ -50,17 +50,14 @@ public Task<HostObjectBuilderResult> Build(
     string modelName,
     Action<string, double?>? onOperationProgressed,
     CancellationToken cancellationToken
-  )
-  {
-    return RevitTask.RunAsync(
-      () => BuildSync(rootObject, projectName, modelName, onOperationProgressed, cancellationToken)
-    );
-  }
-#pragma warning disable IDE0060
+  ) =>
+    RevitTask.RunAsync(() => BuildSync(rootObject, projectName, modelName, onOperationProgressed, cancellationToken));
+
   private HostObjectBuilderResult BuildSync(
     Base rootObject,
     string projectName,
     string modelName,
+#pragma warning disable IDE0060
     Action<string, double?>? onOperationProgressed,
     CancellationToken cancellationToken
   )
@@ -82,6 +79,8 @@ CancellationToken cancellationToken
 
     Dictionary<string, List<string>> applicationIdMap = new();
 
+    // TODO: progress reporting
+    // TODO: cancellation
     var conversionResults = BakeObjects(objectsToConvert, out elementIds);
 
     using (var _ = SpeckleActivityFactory.Start("Commit"))
@@ -90,11 +89,17 @@ CancellationToken cancellationToken
       transactionGroup.Assimilate();
     }
 
+    // TODO: swallow warning
+    // https://github.com/speckleworks/SpeckleRevitReboot/blob/master/SpeckleRevitReboot/ErrorEater.cs
+    // how to use: https://github.com/speckleworks/SpeckleRevitReboot/blob/cc0fb0ee1d3a8a314b58cc98c3de4994fb5816f9/SpeckleRevitReboot/UI/Receiver.cs#L147
     using TransactionGroup createGroupTransaction = new(_contextStack.Current.Document, "Creating group");
     createGroupTransaction.Start();
     _transactionManager.StartTransaction();
 
-    _groupManager.BakeGroups();
+    // TODO: needs try catch and logging
+    // TODO: check selection logic
+    var baseGroupName = $"Project {projectName} - Model {modelName}";
+    _groupManager.BakeGroups(baseGroupName);
 
     using (var _ = SpeckleActivityFactory.Start("Commit"))
     {
@@ -139,7 +144,6 @@ private HostObjectBuilderResult BakeObjects(IEnumerable<TraversalContext> object
       }
 
       elemIds = elementIds;
-
       return new(bakedObjectIds, conversionResults);
     }
   }