chore(revit): drastic cleanup

maybe too drastic, we will see soon

Converters/Revit/Speckle.Converters.RevitShared/Speckle.Converters.RevitShared.projitems

@@ -35,6 +35,7 @@
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\Geometry\EllipseConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\Geometry\ICurveConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\Geometry\LineConverterToHost.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\Geometry\MeshConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\Geometry\PlaneConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\Geometry\PointConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\Geometry\PolylineConverterToHost.cs" />
@@ -47,16 +48,6 @@
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\PolycurveConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ToDirectShape\PolylineConverterToHost.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\Geometry\VectorConverterToHost.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\RenderMaterialToHostConverter.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ToHost\Raw\SurfaceConverterToHost.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\BaseTopLevelConverterToHost.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\BrepToHostTopLevelConverter.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\DirectShapeTopLevelConverterToHost.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\LevelToHostTopLevelConverter.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\GridlineToHostTopLevelConverter.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\MeshToHostTopLevelConverter.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\ModelCurveToSpeckleTopLevelConverter.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)ToHost\TopLevel\PointToHostTopLevelConverter.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToSpeckle\Raw\BeamConversionToSpeckle.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToSpeckle\Raw\BoundarySegmentConversionToSpeckle.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)ToSpeckle\Raw\BraceToSpeckleConverter.cs" />

Converters/Revit/Speckle.Converters.RevitShared/ToHost/Raw/Geometry/ICurveConverterToHost.cs

@@ -62,22 +62,6 @@ public DB.CurveArray Convert(ICurve target)
 
       case SOG.Curve nurbs:
         var n = _curveConverter.Convert(nurbs);
-
-        // poc : in original converter, we were passing a bool into this method 'splitIfClosed'.
-        // https://spockle.atlassian.net/browse/DUI3-462
-        // I'm not entirely sure why we need to split curves, but there are several occurances
-        // of the method being called and overriding the bool to be true.
-
-        //if (IsCurveClosed(n) && splitIfClosed)
-        //{
-        //  var split = SplitCurveInTwoHalves(n);
-        //  curveArray.Append(split.Item1);
-        //  curveArray.Append(split.Item2);
-        //}
-        //else
-        //{
-        //  curveArray.Append(n);
-        //}
         curveArray.Append(n);
         return curveArray;
 
@@ -99,30 +83,4 @@ public DB.CurveArray Convert(ICurve target)
         throw new SpeckleConversionException($"The provided geometry of type {target.GetType()} is not a supported");
     }
   }
-
-  public bool IsCurveClosed(DB.Curve nativeCurve, double tol = 1E-6)
-  {
-    var endPoint = nativeCurve.GetEndPoint(0);
-    var source = nativeCurve.GetEndPoint(1);
-    var distanceTo = endPoint.DistanceTo(source);
-    return distanceTo < tol;
-  }
-
-  public (DB.Curve, DB.Curve) SplitCurveInTwoHalves(DB.Curve nativeCurve)
-  {
-    using var curveArray = new DB.CurveArray();
-    // Revit does not like single curve loop edges, so we split them in two.
-    var start = nativeCurve.GetEndParameter(0);
-    var end = nativeCurve.GetEndParameter(1);
-    var mid = start + (end - start) / 2;
-
-    var a = nativeCurve.Clone();
-    a.MakeBound(start, mid);
-    curveArray.Append(a);
-    var b = nativeCurve.Clone();
-    b.MakeBound(mid, end);
-    curveArray.Append(b);
-
-    return (a, b);
-  }
 }

Converters/Revit/Speckle.Converters.RevitShared/ToHost/TopLevel/MeshToHostTopLevelConverter.cs → Converters/Revit/Speckle.Converters.RevitShared/ToHost/Raw/Geometry/MeshConverterToHost.cs

@@ -1,21 +1,17 @@
 using Autodesk.Revit.DB;
 using Speckle.Converters.Common;
 using Speckle.Converters.Common.Objects;
-using Speckle.Converters.RevitShared.ToSpeckle;
 using Speckle.DoubleNumerics;
 using Speckle.Objects.Other;
 
 namespace Speckle.Converters.RevitShared.ToHost.TopLevel;
 
-[NameAndRankValue(nameof(SOG.Mesh), 0)]
-public class MeshToHostTopLevelConverter
-  : BaseTopLevelConverterToHost<SOG.Mesh, DB.GeometryObject[]>,
-    ITypedConverter<SOG.Mesh, DB.GeometryObject[]>
+public class MeshConverterToHost : ITypedConverter<SOG.Mesh, List<DB.GeometryObject>>
 {
   private readonly ITypedConverter<SOG.Point, DB.XYZ> _pointConverter;
   private readonly ITypedConverter<RenderMaterial, DB.Material> _materialConverter;
 
-  public MeshToHostTopLevelConverter(
+  public MeshConverterToHost(
     ITypedConverter<SOG.Point, XYZ> pointConverter,
     ITypedConverter<RenderMaterial, DB.Material> materialConverter
   )
@@ -24,7 +20,7 @@ public MeshToHostTopLevelConverter(
     _materialConverter = materialConverter;
   }
 
-  public override GeometryObject[] Convert(SOG.Mesh mesh)
+  public List<DB.GeometryObject> Convert(SOG.Mesh mesh)
   {
     TessellatedShapeBuilderTarget target = TessellatedShapeBuilderTarget.Mesh;
     TessellatedShapeBuilderFallback fallback = TessellatedShapeBuilderFallback.Salvage;
@@ -85,7 +81,7 @@ public override GeometryObject[] Convert(SOG.Mesh mesh)
     tsb.Build();
     var result = tsb.GetBuildResult();
 
-    return result.GetGeometricalObjects().ToArray();
+    return result.GetGeometricalObjects().ToList();
   }
 
   private static bool IsNonPlanarQuad(IList<XYZ> points)