feat(revit): wraps receive in correct context

Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Receive/RevitHostObjectBuilder.cs

@@ -1,4 +1,5 @@
 using Autodesk.Revit.DB;
+using Revit.Async;
 using Speckle.Connectors.Revit.HostApp;
 using Speckle.Connectors.Utils.Builders;
 using Speckle.Connectors.Utils.Conversion;
@@ -49,50 +50,63 @@ public Task<HostObjectBuilderResult> Build(
     string modelName,
     Action<string, double?>? onOperationProgressed,
     CancellationToken cancellationToken
-  ) =>
-    _syncToThread.RunOnThread(() =>
-    {
-      using var activity = SpeckleActivityFactory.Start("Build");
-      IEnumerable<TraversalContext> objectsToConvert;
-      using (var _ = SpeckleActivityFactory.Start("Traverse"))
-      {
-        objectsToConvert = _traverseFunction.Traverse(rootObject).Where(obj => obj.Current is not Collection);
-      }
-
-      var elementIds = new List<ElementId>();
-
-      using TransactionGroup transactionGroup =
-        new(_contextStack.Current.Document, $"Received data from {projectName}");
-      transactionGroup.Start();
-      _transactionManager.StartTransaction();
-
-      Dictionary<string, List<string>> applicationIdMap = new();
-      var conversionResults = BakeObjects(objectsToConvert, out elementIds);
+  )
+  {
+    return RevitTask.RunAsync(
+      () => BuildSync(rootObject, projectName, modelName, onOperationProgressed, cancellationToken)
+    );
+  }
+#pragma warning disable IDE0060
+  private HostObjectBuilderResult BuildSync(
+    Base rootObject,
+    string projectName,
+    string modelName,
+    Action<string, double?>? onOperationProgressed,
+    CancellationToken cancellationToken
+  )
+#pragma warning restore IDE0060
+  {
+    using var activity = SpeckleActivityFactory.Start("Build");
+    IEnumerable<TraversalContext> objectsToConvert;
 
-      using (var _ = SpeckleActivityFactory.Start("Commit"))
-      {
-        _transactionManager.CommitTransaction();
-        transactionGroup.Assimilate();
-      }
+    using (var _ = SpeckleActivityFactory.Start("Traverse"))
+    {
+      objectsToConvert = _traverseFunction.Traverse(rootObject).Where(obj => obj.Current is not Collection);
+    }
 
-      //var groupProxies = (rootObject["groupProxies"] as List<object>)?.Cast<GroupProxy>().ToList();
-      _groupManager.CreateGroups();
+    var elementIds = new List<ElementId>();
 
-      // creating group has to be in a separate tranasction, else Revit will show a warning
-      using TransactionGroup createGroupTransaction = new(_contextStack.Current.Document, "Creating group");
-      createGroupTransaction.Start();
-      _transactionManager.StartTransaction();
+    using TransactionGroup transactionGroup = new(_contextStack.Current.Document, $"Received data from {projectName}");
+    transactionGroup.Start();
+    _transactionManager.StartTransaction();
 
-      _contextStack.Current.Document.Create.NewGroup(elementIds);
+    Dictionary<string, List<string>> applicationIdMap = new();
+    var conversionResults = BakeObjects(objectsToConvert, out elementIds);
 
-      using (var _ = SpeckleActivityFactory.Start("Commit"))
-      {
-        _transactionManager.CommitTransaction();
-        createGroupTransaction.Assimilate();
-      }
+    using (var _ = SpeckleActivityFactory.Start("Commit"))
+    {
+      _transactionManager.CommitTransaction();
+      transactionGroup.Assimilate();
+    }
 
-      return conversionResults;
-    });
+    //var groupProxies = (rootObject["groupProxies"] as List<object>)?.Cast<GroupProxy>().ToList();
+    //_groupManager.CreateGroups();
+
+    // creating group has to be in a separate tranasction, else Revit will show a warning
+    // using TransactionGroup createGroupTransaction = new(_contextStack.Current.Document, "Creating group");
+    // createGroupTransaction.Start();
+    // _transactionManager.StartTransaction();
+    //
+    // _contextStack.Current.Document.Create.NewGroup(elementIds);
+    //
+    // using (var _ = SpeckleActivityFactory.Start("Commit"))
+    // {
+    //   _transactionManager.CommitTransaction();
+    //   createGroupTransaction.Assimilate();
+    // }
+
+    return conversionResults;
+  }
 
   // POC: Potentially refactor out into an IObjectBaker.
   private HostObjectBuilderResult BakeObjects(IEnumerable<TraversalContext> objectsGraph, out List<ElementId> elemIds)
@@ -129,7 +143,7 @@ private HostObjectBuilderResult BakeObjects(IEnumerable<TraversalContext> object
       }
 
       // create group
-      //_contextStack.Current.Document.Create.NewGroup(elementIds);
+      _contextStack.Current.Document.Create.NewGroup(elementIds);
       elemIds = elementIds;
 
       return new(bakedObjectIds, conversionResults);