Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(revit): CNX-470 add support for layer render materials #243

Conversation

oguzhankoral
Copy link
Member

Sent from rhino as meshes -> https://latest.speckle.systems/projects/126cd4b7bb/models/f3b0250890
It doesn't work with Breps, because on converter we don't know the relationship between parent and its list of displayValues.

Revit_oyFlaOYJg4

Copy link

linear bot commented Sep 16, 2024

@oguzhankoral oguzhankoral changed the base branch from dev to revit-receive September 16, 2024 16:12
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 7.95%. Comparing base (81f35f6) to head (90834bd).
Report is 6 commits behind head on revit-receive.

Files with missing lines Patch % Lines
...RevitShared/Helpers/RevitMaterialCacheSingleton.cs 0.00% 1 Missing ⚠️
...tShared/ToHost/Raw/Geometry/MeshConverterToHost.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           revit-receive    #243      +/-   ##
================================================
- Coverage           7.97%   7.95%   -0.03%     
================================================
  Files                233     233              
  Lines               4325    4337      +12     
  Branches             492     498       +6     
================================================
  Hits                 345     345              
- Misses              3965    3977      +12     
  Partials              15      15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didimitrie didimitrie merged commit 1de58a3 into revit-receive Sep 16, 2024
5 checks passed
@didimitrie didimitrie deleted the oguzhan/cnx-470-add-support-for-layer-render-materials branch September 16, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants