Jedd/cxpla 55 add required keyword for more geometry types #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ired-keyword-for-more-geometry-types
…ired-keyword-for-more-geometry-types
JR-Morgan
requested review from
AlanRynne
and removed request for
KatKatKateryna
* fix arcgis units * usings * correct units --------- Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>
|
ready for review, but until specklesystems/speckle-sharp-sdk#101 is made this can't be merged |
AlanRynne
requested changes
Sep 13, 2024
| @@ -26,7 +26,8 @@ public IReadOnlyList<Base> Convert(ACG.Multipatch target) | |||
| { | |||
| List<Base> converted = new(); | |||
| // placeholder, needs to be declared in order to be used in the Ring patch type | |||
| SGIS.PolygonGeometry3d polygonGeom = new() { }; | |||
| SGIS.PolygonGeometry3d polygonGeom = | |||
| new() { units = _contextStack.Current.Document.ActiveCRSoffsetRotation.SpeckleUnitString }; | |||
There was a problem hiding this comment.
Is this SpeckleUnitString computed for every call?
There was a problem hiding this comment.
Looks like it's being set once, calculated from ACG.SpatialReference, this Document is our own ArcGISDocument class (I presume because we need reference to both the Arcgis Project, Map and CRSoffsetRotation
This will need some cleanup with the record context changes that you and @adamhathcock have worked on. For now I'm tempted to leave as is.
...it/Speckle.Converters.RevitShared/ToSpeckle/TopLevel/TopographyTopLevelConverterToSpeckle.cs
Outdated
Show resolved
Hide resolved
Sdk/Speckle.Connectors.Utils/Instances/InstanceObjectsManager.cs
Outdated
Show resolved
Hide resolved
…ired-keyword-for-more-geometry-types
AlanRynne
approved these changes
Sep 16, 2024
JR-Morgan
deleted the
jedd/cxpla-55-add-required-keyword-for-more-geometry-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connectors updates for specklesystems/speckle-sharp-sdk#101 changes
Changes several conversion functions to comply with using respecting the
requiredkeyword.importantly, I've made it so we are now setting units on several Revit and ArcGIS (still todo) conversions where previously we were defaulting to Meters erroneously.