Skip to content

Commit

Permalink
Jedd/cxpla 55 add required keyword for more geometry types (#220)
Browse files Browse the repository at this point in the history 
* Nullability of TryGet function

* blip

* Connector side changes

* Fixes

* Fixed other SDK changes

* Fixed Meters defaulting in Revit

* Agis fix required units (#224)

* fix arcgis units

* usings

* correct units

---------

Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>

* Fixed compiler errors

* Resolved PR Comments

* Fixed last revit units issue

* extras

* Bumped sdk deps

---------

Co-authored-by: KatKatKateryna <89912278+KatKatKateryna@users.noreply.github.com>
  • Loading branch information
@JR-Morgan @KatKatKateryna
JR-Morgan and KatKatKateryna authored Sep 16, 2024
1 parent 466ac5e commit eb8f8de
Show file tree
Hide file tree
Showing 82 changed files with 827 additions and 677 deletions.
3 changes: 3 additions & 0 deletions .editorconfig
View file
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,9 @@ dotnet_diagnostic.ide0290.severity = suggestion # primary constructors: subjecti
dotnet_diagnostic.ide0290.severity = suggestion # Use primary constructor: Subjective
dotnet_diagnostic.ide0037.severity = suggestion # Use inferred member names: Sometimes its nice to be explicit
dotnet_diagnostic.ide0301.severity = suggestion # Use collection expression for empty: Subjective, intent
dotnet_diagnostic.ide0021.severity = suggestion # Use expression body for constructors : Subjective
dotnet_diagnostic.ide0090.severity = suggestion # Simplify new expression : Subjective

dotnet_diagnostic.ide0047.severity = suggestion # Parentheses preferences: IDEs don't properly pick it up

# Maintainability rules
Expand Down
28 changes: 14 additions & 14 deletions Connectors/ArcGIS/Speckle.Connectors.ArcGIS3/packages.lock.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,8 @@
},
"Speckle.Sdk.Logging": {
"type": "Transitive",
"resolved": "3.0.1-rc.118",
"contentHash": "rzzJTTlTyeC7O2XOBAGqTrAbd7vk245mXat1v2okqlnEIvoAQj+kiId53v69i+3jv9svoqohkvaWJ2ZD8MkDXA=="
"resolved": "3.1.0-dev.136",
"contentHash": "X88GqPef05lRuUzxCaR/inWi7eMEpbI8SlOoUaqsNn9mwDiutppIvva3VRK5ARaASvPsunyzWV40TSD6+VH4eA=="
},
"SQLitePCLRaw.bundle_e_sqlite3": {
"type": "Transitive",
Expand Down Expand Up @@ -240,7 +240,7 @@
"Microsoft.Extensions.Logging.Abstractions": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Connectors.Utils": "[1.0.0, )",
"Speckle.Sdk": "[3.0.1-rc.118, )",
"Speckle.Sdk": "[3.1.0-dev.136, )",
"System.Threading.Tasks.Dataflow": "[6.0.0, )"
}
},
Expand All @@ -256,8 +256,8 @@
"dependencies": {
"Microsoft.Extensions.Logging": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Objects": "[3.0.1-rc.118, )",
"Speckle.Sdk": "[3.0.1-rc.118, )"
"Speckle.Objects": "[3.1.0-dev.136, )",
"Speckle.Sdk": "[3.1.0-dev.136, )"
}
},
"speckle.converters.arcgis3": {
Expand All @@ -279,7 +279,7 @@
"dependencies": {
"Microsoft.Extensions.Logging.Abstractions": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Objects": "[3.0.1-rc.118, )"
"Speckle.Objects": "[3.1.0-dev.136, )"
}
},
"speckle.converters.common.dependencyinjection": {
Expand Down Expand Up @@ -315,18 +315,18 @@
},
"Speckle.Objects": {
"type": "CentralTransitive",
"requested": "[3.0.1-rc.118, )",
"resolved": "3.0.1-rc.118",
"contentHash": "5VgLOrOMGsdGqZJwZXjyUrLX+kO+wb6qy0nQgDWuHG+aZdPyGmjyLW3YeaCnDQBu/uDJnQu7ddj5LqbIlTif0w==",
"requested": "[3.1.0-dev.136, )",
"resolved": "3.1.0-dev.136",
"contentHash": "jibrr1zEne7RVNumSd/SkFMRQw5LZS3stM3zk6ZKadAv6eRfnvPB1ZfHhqDiB07TX5Y0SuFCYkI1X5xvLrZsxg==",
"dependencies": {
"Speckle.Sdk": "3.0.1-rc.118"
"Speckle.Sdk": "3.1.0-dev.136"
}
},
"Speckle.Sdk": {
"type": "CentralTransitive",
"requested": "[3.0.1-rc.118, )",
"resolved": "3.0.1-rc.118",
"contentHash": "cKiVG0LMRmF4vgTWq2L8xOYoTGiAF9n8OyycmWHCdW6l7wLTre6B4AOWtW9j9NA427C3sJmZ4R9dSbNYRLxDRQ==",
"requested": "[3.1.0-dev.136, )",
"resolved": "3.1.0-dev.136",
"contentHash": "rr+TypUJCmLNYa/9TOtFrITZ+5s9AIO7mYqmDwJZQwmu7IQeherqbBPAt9LoCJXcfTQoBW4ci0PmknPbDoTKAw==",
"dependencies": {
"GraphQL.Client": "6.0.0",
"Microsoft.CSharp": "4.7.0",
Expand All @@ -336,7 +336,7 @@
"Polly.Extensions.Http": "3.0.0",
"Speckle.DoubleNumerics": "4.0.1",
"Speckle.Newtonsoft.Json": "13.0.2",
"Speckle.Sdk.Logging": "3.0.1-rc.118",
"Speckle.Sdk.Logging": "3.1.0-dev.136",
"System.Text.Json": "5.0.2"
}
},
Expand Down
28 changes: 14 additions & 14 deletions Connectors/Autocad/Speckle.Connectors.Autocad2022/packages.lock.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,8 @@
},
"Speckle.Sdk.Logging": {
"type": "Transitive",
"resolved": "3.0.1-rc.118",
"contentHash": "rzzJTTlTyeC7O2XOBAGqTrAbd7vk245mXat1v2okqlnEIvoAQj+kiId53v69i+3jv9svoqohkvaWJ2ZD8MkDXA=="
"resolved": "3.1.0-dev.136",
"contentHash": "X88GqPef05lRuUzxCaR/inWi7eMEpbI8SlOoUaqsNn9mwDiutppIvva3VRK5ARaASvPsunyzWV40TSD6+VH4eA=="
},
"SQLitePCLRaw.bundle_e_sqlite3": {
"type": "Transitive",
Expand Down Expand Up @@ -318,7 +318,7 @@
"Microsoft.Extensions.Logging.Abstractions": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Connectors.Utils": "[1.0.0, )",
"Speckle.Sdk": "[3.0.1-rc.118, )",
"Speckle.Sdk": "[3.1.0-dev.136, )",
"System.Threading.Tasks.Dataflow": "[6.0.0, )"
}
},
Expand All @@ -334,8 +334,8 @@
"dependencies": {
"Microsoft.Extensions.Logging": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Objects": "[3.0.1-rc.118, )",
"Speckle.Sdk": "[3.0.1-rc.118, )"
"Speckle.Objects": "[3.1.0-dev.136, )",
"Speckle.Sdk": "[3.1.0-dev.136, )"
}
},
"speckle.converters.autocad2022": {
Expand All @@ -358,7 +358,7 @@
"dependencies": {
"Microsoft.Extensions.Logging.Abstractions": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Objects": "[3.0.1-rc.118, )"
"Speckle.Objects": "[3.1.0-dev.136, )"
}
},
"speckle.converters.common.dependencyinjection": {
Expand Down Expand Up @@ -403,18 +403,18 @@
},
"Speckle.Objects": {
"type": "CentralTransitive",
"requested": "[3.0.1-rc.118, )",
"resolved": "3.0.1-rc.118",
"contentHash": "5VgLOrOMGsdGqZJwZXjyUrLX+kO+wb6qy0nQgDWuHG+aZdPyGmjyLW3YeaCnDQBu/uDJnQu7ddj5LqbIlTif0w==",
"requested": "[3.1.0-dev.136, )",
"resolved": "3.1.0-dev.136",
"contentHash": "jibrr1zEne7RVNumSd/SkFMRQw5LZS3stM3zk6ZKadAv6eRfnvPB1ZfHhqDiB07TX5Y0SuFCYkI1X5xvLrZsxg==",
"dependencies": {
"Speckle.Sdk": "3.0.1-rc.118"
"Speckle.Sdk": "3.1.0-dev.136"
}
},
"Speckle.Sdk": {
"type": "CentralTransitive",
"requested": "[3.0.1-rc.118, )",
"resolved": "3.0.1-rc.118",
"contentHash": "cKiVG0LMRmF4vgTWq2L8xOYoTGiAF9n8OyycmWHCdW6l7wLTre6B4AOWtW9j9NA427C3sJmZ4R9dSbNYRLxDRQ==",
"requested": "[3.1.0-dev.136, )",
"resolved": "3.1.0-dev.136",
"contentHash": "rr+TypUJCmLNYa/9TOtFrITZ+5s9AIO7mYqmDwJZQwmu7IQeherqbBPAt9LoCJXcfTQoBW4ci0PmknPbDoTKAw==",
"dependencies": {
"GraphQL.Client": "6.0.0",
"Microsoft.CSharp": "4.7.0",
Expand All @@ -424,7 +424,7 @@
"Polly.Extensions.Http": "3.0.0",
"Speckle.DoubleNumerics": "4.0.1",
"Speckle.Newtonsoft.Json": "13.0.2",
"Speckle.Sdk.Logging": "3.0.1-rc.118",
"Speckle.Sdk.Logging": "3.1.0-dev.136",
"System.Text.Json": "5.0.2"
}
},
Expand Down
28 changes: 14 additions & 14 deletions Connectors/Autocad/Speckle.Connectors.Autocad2023/packages.lock.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,8 @@
},
"Speckle.Sdk.Logging": {
"type": "Transitive",
"resolved": "3.0.1-rc.118",
"contentHash": "rzzJTTlTyeC7O2XOBAGqTrAbd7vk245mXat1v2okqlnEIvoAQj+kiId53v69i+3jv9svoqohkvaWJ2ZD8MkDXA=="
"resolved": "3.1.0-dev.136",
"contentHash": "X88GqPef05lRuUzxCaR/inWi7eMEpbI8SlOoUaqsNn9mwDiutppIvva3VRK5ARaASvPsunyzWV40TSD6+VH4eA=="
},
"SQLitePCLRaw.bundle_e_sqlite3": {
"type": "Transitive",
Expand Down Expand Up @@ -318,7 +318,7 @@
"Microsoft.Extensions.Logging.Abstractions": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Connectors.Utils": "[1.0.0, )",
"Speckle.Sdk": "[3.0.1-rc.118, )",
"Speckle.Sdk": "[3.1.0-dev.136, )",
"System.Threading.Tasks.Dataflow": "[6.0.0, )"
}
},
Expand All @@ -334,8 +334,8 @@
"dependencies": {
"Microsoft.Extensions.Logging": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Objects": "[3.0.1-rc.118, )",
"Speckle.Sdk": "[3.0.1-rc.118, )"
"Speckle.Objects": "[3.1.0-dev.136, )",
"Speckle.Sdk": "[3.1.0-dev.136, )"
}
},
"speckle.converters.autocad2023": {
Expand All @@ -358,7 +358,7 @@
"dependencies": {
"Microsoft.Extensions.Logging.Abstractions": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Objects": "[3.0.1-rc.118, )"
"Speckle.Objects": "[3.1.0-dev.136, )"
}
},
"speckle.converters.common.dependencyinjection": {
Expand Down Expand Up @@ -403,18 +403,18 @@
},
"Speckle.Objects": {
"type": "CentralTransitive",
"requested": "[3.0.1-rc.118, )",
"resolved": "3.0.1-rc.118",
"contentHash": "5VgLOrOMGsdGqZJwZXjyUrLX+kO+wb6qy0nQgDWuHG+aZdPyGmjyLW3YeaCnDQBu/uDJnQu7ddj5LqbIlTif0w==",
"requested": "[3.1.0-dev.136, )",
"resolved": "3.1.0-dev.136",
"contentHash": "jibrr1zEne7RVNumSd/SkFMRQw5LZS3stM3zk6ZKadAv6eRfnvPB1ZfHhqDiB07TX5Y0SuFCYkI1X5xvLrZsxg==",
"dependencies": {
"Speckle.Sdk": "3.0.1-rc.118"
"Speckle.Sdk": "3.1.0-dev.136"
}
},
"Speckle.Sdk": {
"type": "CentralTransitive",
"requested": "[3.0.1-rc.118, )",
"resolved": "3.0.1-rc.118",
"contentHash": "cKiVG0LMRmF4vgTWq2L8xOYoTGiAF9n8OyycmWHCdW6l7wLTre6B4AOWtW9j9NA427C3sJmZ4R9dSbNYRLxDRQ==",
"requested": "[3.1.0-dev.136, )",
"resolved": "3.1.0-dev.136",
"contentHash": "rr+TypUJCmLNYa/9TOtFrITZ+5s9AIO7mYqmDwJZQwmu7IQeherqbBPAt9LoCJXcfTQoBW4ci0PmknPbDoTKAw==",
"dependencies": {
"GraphQL.Client": "6.0.0",
"Microsoft.CSharp": "4.7.0",
Expand All @@ -424,7 +424,7 @@
"Polly.Extensions.Http": "3.0.0",
"Speckle.DoubleNumerics": "4.0.1",
"Speckle.Newtonsoft.Json": "13.0.2",
"Speckle.Sdk.Logging": "3.0.1-rc.118",
"Speckle.Sdk.Logging": "3.1.0-dev.136",
"System.Text.Json": "5.0.2"
}
},
Expand Down
28 changes: 14 additions & 14 deletions Connectors/Autocad/Speckle.Connectors.Autocad2024/packages.lock.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,8 @@
},
"Speckle.Sdk.Logging": {
"type": "Transitive",
"resolved": "3.0.1-rc.118",
"contentHash": "rzzJTTlTyeC7O2XOBAGqTrAbd7vk245mXat1v2okqlnEIvoAQj+kiId53v69i+3jv9svoqohkvaWJ2ZD8MkDXA=="
"resolved": "3.1.0-dev.136",
"contentHash": "X88GqPef05lRuUzxCaR/inWi7eMEpbI8SlOoUaqsNn9mwDiutppIvva3VRK5ARaASvPsunyzWV40TSD6+VH4eA=="
},
"SQLitePCLRaw.bundle_e_sqlite3": {
"type": "Transitive",
Expand Down Expand Up @@ -318,7 +318,7 @@
"Microsoft.Extensions.Logging.Abstractions": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Connectors.Utils": "[1.0.0, )",
"Speckle.Sdk": "[3.0.1-rc.118, )",
"Speckle.Sdk": "[3.1.0-dev.136, )",
"System.Threading.Tasks.Dataflow": "[6.0.0, )"
}
},
Expand All @@ -334,8 +334,8 @@
"dependencies": {
"Microsoft.Extensions.Logging": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Objects": "[3.0.1-rc.118, )",
"Speckle.Sdk": "[3.0.1-rc.118, )"
"Speckle.Objects": "[3.1.0-dev.136, )",
"Speckle.Sdk": "[3.1.0-dev.136, )"
}
},
"speckle.converters.autocad2024": {
Expand All @@ -359,7 +359,7 @@
"dependencies": {
"Microsoft.Extensions.Logging.Abstractions": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Objects": "[3.0.1-rc.118, )"
"Speckle.Objects": "[3.1.0-dev.136, )"
}
},
"speckle.converters.common.dependencyinjection": {
Expand Down Expand Up @@ -404,18 +404,18 @@
},
"Speckle.Objects": {
"type": "CentralTransitive",
"requested": "[3.0.1-rc.118, )",
"resolved": "3.0.1-rc.118",
"contentHash": "5VgLOrOMGsdGqZJwZXjyUrLX+kO+wb6qy0nQgDWuHG+aZdPyGmjyLW3YeaCnDQBu/uDJnQu7ddj5LqbIlTif0w==",
"requested": "[3.1.0-dev.136, )",
"resolved": "3.1.0-dev.136",
"contentHash": "jibrr1zEne7RVNumSd/SkFMRQw5LZS3stM3zk6ZKadAv6eRfnvPB1ZfHhqDiB07TX5Y0SuFCYkI1X5xvLrZsxg==",
"dependencies": {
"Speckle.Sdk": "3.0.1-rc.118"
"Speckle.Sdk": "3.1.0-dev.136"
}
},
"Speckle.Sdk": {
"type": "CentralTransitive",
"requested": "[3.0.1-rc.118, )",
"resolved": "3.0.1-rc.118",
"contentHash": "cKiVG0LMRmF4vgTWq2L8xOYoTGiAF9n8OyycmWHCdW6l7wLTre6B4AOWtW9j9NA427C3sJmZ4R9dSbNYRLxDRQ==",
"requested": "[3.1.0-dev.136, )",
"resolved": "3.1.0-dev.136",
"contentHash": "rr+TypUJCmLNYa/9TOtFrITZ+5s9AIO7mYqmDwJZQwmu7IQeherqbBPAt9LoCJXcfTQoBW4ci0PmknPbDoTKAw==",
"dependencies": {
"GraphQL.Client": "6.0.0",
"Microsoft.CSharp": "4.7.0",
Expand All @@ -425,7 +425,7 @@
"Polly.Extensions.Http": "3.0.0",
"Speckle.DoubleNumerics": "4.0.1",
"Speckle.Newtonsoft.Json": "13.0.2",
"Speckle.Sdk.Logging": "3.0.1-rc.118",
"Speckle.Sdk.Logging": "3.1.0-dev.136",
"System.Text.Json": "5.0.2"
}
},
Expand Down
28 changes: 14 additions & 14 deletions Connectors/Autocad/Speckle.Connectors.Autocad2025/packages.lock.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@
},
"Speckle.Sdk.Logging": {
"type": "Transitive",
"resolved": "3.0.1-rc.118",
"contentHash": "rzzJTTlTyeC7O2XOBAGqTrAbd7vk245mXat1v2okqlnEIvoAQj+kiId53v69i+3jv9svoqohkvaWJ2ZD8MkDXA=="
"resolved": "3.1.0-dev.136",
"contentHash": "X88GqPef05lRuUzxCaR/inWi7eMEpbI8SlOoUaqsNn9mwDiutppIvva3VRK5ARaASvPsunyzWV40TSD6+VH4eA=="
},
"SQLitePCLRaw.bundle_e_sqlite3": {
"type": "Transitive",
Expand Down Expand Up @@ -234,7 +234,7 @@
"Microsoft.Extensions.Logging.Abstractions": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Connectors.Utils": "[1.0.0, )",
"Speckle.Sdk": "[3.0.1-rc.118, )",
"Speckle.Sdk": "[3.1.0-dev.136, )",
"System.Threading.Tasks.Dataflow": "[6.0.0, )"
}
},
Expand All @@ -250,8 +250,8 @@
"dependencies": {
"Microsoft.Extensions.Logging": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Objects": "[3.0.1-rc.118, )",
"Speckle.Sdk": "[3.0.1-rc.118, )"
"Speckle.Objects": "[3.1.0-dev.136, )",
"Speckle.Sdk": "[3.1.0-dev.136, )"
}
},
"speckle.converters.autocad2025": {
Expand All @@ -275,7 +275,7 @@
"dependencies": {
"Microsoft.Extensions.Logging.Abstractions": "[3.1.0, )",
"Speckle.Autofac": "[1.0.0, )",
"Speckle.Objects": "[3.0.1-rc.118, )"
"Speckle.Objects": "[3.1.0-dev.136, )"
}
},
"speckle.converters.common.dependencyinjection": {
Expand Down Expand Up @@ -317,18 +317,18 @@
},
"Speckle.Objects": {
"type": "CentralTransitive",
"requested": "[3.0.1-rc.118, )",
"resolved": "3.0.1-rc.118",
"contentHash": "5VgLOrOMGsdGqZJwZXjyUrLX+kO+wb6qy0nQgDWuHG+aZdPyGmjyLW3YeaCnDQBu/uDJnQu7ddj5LqbIlTif0w==",
"requested": "[3.1.0-dev.136, )",
"resolved": "3.1.0-dev.136",
"contentHash": "jibrr1zEne7RVNumSd/SkFMRQw5LZS3stM3zk6ZKadAv6eRfnvPB1ZfHhqDiB07TX5Y0SuFCYkI1X5xvLrZsxg==",
"dependencies": {
"Speckle.Sdk": "3.0.1-rc.118"
"Speckle.Sdk": "3.1.0-dev.136"
}
},
"Speckle.Sdk": {
"type": "CentralTransitive",
"requested": "[3.0.1-rc.118, )",
"resolved": "3.0.1-rc.118",
"contentHash": "cKiVG0LMRmF4vgTWq2L8xOYoTGiAF9n8OyycmWHCdW6l7wLTre6B4AOWtW9j9NA427C3sJmZ4R9dSbNYRLxDRQ==",
"requested": "[3.1.0-dev.136, )",
"resolved": "3.1.0-dev.136",
"contentHash": "rr+TypUJCmLNYa/9TOtFrITZ+5s9AIO7mYqmDwJZQwmu7IQeherqbBPAt9LoCJXcfTQoBW4ci0PmknPbDoTKAw==",
"dependencies": {
"GraphQL.Client": "6.0.0",
"Microsoft.CSharp": "4.7.0",
Expand All @@ -338,7 +338,7 @@
"Polly.Extensions.Http": "3.0.0",
"Speckle.DoubleNumerics": "4.0.1",
"Speckle.Newtonsoft.Json": "13.0.2",
"Speckle.Sdk.Logging": "3.0.1-rc.118",
"Speckle.Sdk.Logging": "3.1.0-dev.136",
"System.Text.Json": "5.0.2"
}
},
Expand Down
Loading

0 comments on commit eb8f8de

Please sign in to comment.