Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agis fix required units #224

Conversation

KatKatKateryna
Copy link
Contributor

@KatKatKateryna KatKatKateryna commented Sep 6, 2024

replaced .Meters placeholders; added units setter where possible

@KatKatKateryna
Copy link
Contributor Author

@JR-Morgan this seems ready to merge, but it hasn't been tested, as Local setup build fails

@JR-Morgan JR-Morgan self-requested a review September 9, 2024 14:23
@JR-Morgan JR-Morgan self-assigned this Sep 9, 2024
@JR-Morgan JR-Morgan merged commit 957a4ed into jedd/cxpla-55-add-required-keyword-for-more-geometry-types Sep 10, 2024
1 of 3 checks passed
@JR-Morgan JR-Morgan deleted the AGIS_fix-required-units branch September 10, 2024 12:27
JR-Morgan added a commit that referenced this pull request Sep 16, 2024
* Nullability of TryGet function

* blip

* Connector side changes

* Fixes

* Fixed other SDK changes

* Fixed Meters defaulting in Revit

* Agis fix required units (#224)

* fix arcgis units

* usings

* correct units

---------

Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>

* Fixed compiler errors

* Resolved PR Comments

* Fixed last revit units issue

* extras

* Bumped sdk deps

---------

Co-authored-by: KatKatKateryna <89912278+KatKatKateryna@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants