Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jedd/cxpla 55 add required keyword for more geometry types #101

Merged

Conversation

JR-Morgan
Copy link
Member

No description provided.

Copy link

linear bot commented Sep 4, 2024

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 45.02618% with 105 lines in your changes missing coverage. Please review.

Project coverage is 46.06%. Comparing base (30a3533) to head (a9ba6a8).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/Speckle.Objects/Geometry/Line.cs 0.00% 16 Missing ⚠️
src/Speckle.Objects/Geometry/Polycurve.cs 0.00% 12 Missing ⚠️
src/Speckle.Objects/Geometry/Point.cs 15.38% 11 Missing ⚠️
src/Speckle.Objects/Other/Block.cs 0.00% 9 Missing ⚠️
src/Speckle.Objects/Geometry/Vector.cs 27.27% 7 Missing and 1 partial ⚠️
src/Speckle.Objects/Other/Transform.cs 0.00% 7 Missing ⚠️
src/Speckle.Objects/Geometry/PolylineExtensions.cs 0.00% 6 Missing ⚠️
...le.Objects/Structural/CSI/Geometry/CSIElement1D.cs 0.00% 4 Missing ⚠️
...Speckle.Objects/Structural/CSI/Geometry/CSINode.cs 0.00% 4 Missing ⚠️
...le.Objects/Structural/GSA/Geometry/GSAElement1D.cs 0.00% 4 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #101       +/-   ##
===========================================
+ Coverage   30.61%   46.06%   +15.45%     
===========================================
  Files         381      393       +12     
  Lines       12949    13810      +861     
  Branches     1029     1036        +7     
===========================================
+ Hits         3964     6362     +2398     
+ Misses       8776     7180     -1596     
- Partials      209      268       +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan JR-Morgan requested review from AlanRynne and removed request for clairekuang and KatKatKateryna September 10, 2024 12:20
@JR-Morgan JR-Morgan marked this pull request as ready for review September 10, 2024 15:01
Copy link
Member

@adamhathcock adamhathcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I follow everything

@JR-Morgan JR-Morgan merged commit ccb4f54 into dev Sep 13, 2024
4 checks passed
@JR-Morgan JR-Morgan deleted the jedd/cxpla-55-add-required-keyword-for-more-geometry-types branch September 13, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants