Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jedd/cxpla 55 add required keyword for more geometry types #220

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes
  • Loading branch information
JR-Morgan committed Sep 5, 2024
commit 987a01dad881791091e575db18994df90ff05d27

This file was deleted.

24 changes: 6 additions & 18 deletions Sdk/Speckle.Connectors.Utils/Instances/InstanceObjectsManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,31 +8,19 @@ public interface IInstanceObjectsManager<THostObjectType, TAppIdMapValueType>
void AddInstanceProxy(string objectId, InstanceProxy instanceProxy);
void AddDefinitionProxy(string objectId, InstanceDefinitionProxy instanceDefinitionProxy);
void AddAtomicObject(string objectId, THostObjectType obj);
void AddInstanceProxiesByDefinitionId(
string definitionId,
System.Collections.Generic.List<Speckle.Sdk.Models.Instances.InstanceProxy> instanceProxies
);
global::Speckle.Connectors.Utils.Instances.UnpackResult<THostObjectType> GetUnpackResult();
void AddInstanceProxiesByDefinitionId(string definitionId, List<InstanceProxy> instanceProxies);
UnpackResult<THostObjectType> GetUnpackResult();
bool TryGetInstanceProxiesFromDefinitionId(
string definitionId,
out System.Collections.Generic.List<Speckle.Sdk.Models.Instances.InstanceProxy>? instanceProxiesWithSameDefinition
[NotNullWhen(true)] out List<InstanceProxy>? instanceProxiesWithSameDefinition
);
bool TryGetInstanceDefinitionProxy(
string definitionId,
out Speckle.Sdk.Models.Instances.InstanceDefinitionProxy? instanceDefinitionProxy
[NotNullWhen(true)] out InstanceDefinitionProxy? instanceDefinitionProxy
);
global::Speckle.Sdk.Models.Instances.InstanceProxy GetInstanceProxy(string instanceId);
InstanceProxy GetInstanceProxy(string instanceId);

/// <summary>
/// Update children max depths whenever definition proxy is found on the unpacked dictionary (<see cref="F:Speckle.Connectors.Utils.Instances.InstanceObjectsManager`2._definitionProxies"/>).
/// Even if definition unpacked before, max depth of its children must be updated if upcoming max depth is higher than existing one.
/// </summary>
/// <param name="definitionProxy"> Definition proxy to update max depth of its children.</param>
/// <param name="depthDifference"> Value to increase max depth of children.</param>
void UpdateChildrenMaxDepth(
global::Speckle.Sdk.Models.Instances.InstanceDefinitionProxy definitionProxy,
int depthDifference
);
void UpdateChildrenMaxDepth(InstanceDefinitionProxy definitionProxy, int depthDifference);
}

// [GenerateAutoInterface]
Expand Down
Loading