Skip to content

[DO NOT MERGE] Add support for async io #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 396 commits into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] Add support for async io #2608

wants to merge 396 commits into from
+63,973 −3,592

Conversation

@sfc-gh-turbaszek
Copy link
Contributor

@sfc-gh-turbaszek sfc-gh-turbaszek commented Oct 28, 2025

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

sfc-gh-mmishchenko and others added 30 commits September 2, 2025 14:31
@sfc-gh-mmishchenko @sfc-gh-pczajka
NO-SNOW acquiring a lock on local OCSP cache will use a timeout (#2280)
344a768
@sfc-gh-pmansour @sfc-gh-pczajka
Accept both v1 and v2 Entra ID issuer formats for WIF (#2281)
30f0116
@sfc-gh-pczajka
[ASYNC] apply #2281 to async code
5b3c6ee
@sfc-gh-mmishchenko @sfc-gh-pczajka
SNOW-2048239 revert zero timeout for oscp cache lock (#2283)
9ef4e65
@sfc-gh-pczajka
[ASYNC] remove flaky marker from OCSP tests after #2283
c1c4176
@sfc-gh-mmishchenko @sfc-gh-pczajka
SNOW-1993520 update tested_reqs for 3.14.1 release (#2287)
2d58c20 
Co-authored-by: github-actions <github-actions@github.com>
@sfc-gh-pczajka
Review fixes - add secret filter to external libraries + tests
3b893fb
@sfc-gh-pczajka
Skip test removed later
8b64a41
@sfc-gh-pczajka
skip failing additional check for further investigation
694b77a
@sfc-gh-pczajka
Temporarily reduce number of jobs: SNOW-2311643
968aa0f
@sfc-gh-zyao @sfc-gh-pczajka
SNOW-1963078 Port _upload / _download / _upload_stream / _download_st… (
aa56a05 
#2198)

(cherry picked from commit a3229c3)
@sfc-gh-fpawlowski @sfc-gh-pczajka
[Async] Apply #2198 to async code
1ae0628
@sfc-gh-mkubik @sfc-gh-pczajka
SNOW-1989239 - prevent silent failures on nano-arrow conversion (#2227)
e7a4b59 
Co-authored-by: Adam Ling <adam.ling@snowflake.com>

(cherry picked from commit 5e96035)
@sfc-gh-fpawlowski @sfc-gh-pczajka
[Async] Apply #2227 to async code
4498aa2
@sfc-gh-mkubik @sfc-gh-pczajka
NO-SNOW skip out of range year test on old driver (#2243)
45748ca 
(cherry picked from commit 2ab3745)
@sfc-gh-fpawlowski @sfc-gh-pczajka
[Async] Apply #2243 to async code
6fb42bd
@sfc-gh-mkubik @sfc-gh-pczajka
SNOW-191538 remove copyright headers (#2238)
1e28b6b 
(cherry picked from commit 813bbd8)
@sfc-gh-fpawlowski @sfc-gh-pczajka
[Async] Apply #2238 to async code
2314960
@sfc-gh-pbulawa @sfc-gh-pczajka
SNOW-1789751: Pass GCS regional and virtual params (#2241)
172dfb7 
(cherry picked from commit 985ec5e)
@sfc-gh-fpawlowski @sfc-gh-pczajka
[Async] Apply 2241 to async code
91585ab
@sfc-gh-zyao @sfc-gh-pczajka
SNOW-2019505 fix inconsistent force_put_overwrite value for _upload a… (
6d5d13d 
#2247)

(cherry picked from commit e200620)
@sfc-gh-fpawlowski @sfc-gh-pczajka
[Async] Apply #2247 to async code
6336909
@sfc-gh-pbulawa @sfc-gh-pczajka
SNOW-1896089: Lower log level (#2251)
e8732ea 
(cherry picked from commit 44313a3)
@sfc-gh-fpawlowski @sfc-gh-pczajka
[Async] Apply #2251 to async code
26f2381
@sfc-gh-jszczerbinski @sfc-gh-pczajka
SNOW-2026002: Invalid url became valid (#2252)
6897237 
(cherry picked from commit 3a798e8)
@sfc-gh-lspiegelberg @sfc-gh-pczajka
SNOW-2011670 Allow url parameter requestId to be set with statement p…
c535e8f 
…arams (#2240)

As part of the Snowpark IR project, we will send AST as part of the request. To restore them faithfully on the server-side and avoid introducing yet another layer of indirection, we would like to use the HTTP Request Id. Currently, this Request Id is generated on the client as part of issuing the query. With this PR we introduce a new (client-side) statement parameter requestId that allows to overwrite the automatically generated request Id. requestId must be a valid UUID4 or UUID4 string.

(cherry picked from commit 6e214d0)
@sfc-gh-fpawlowski @sfc-gh-pczajka
[Async] Apply #2240 to async code
4d3f07f
@sfc-gh-mkubik @sfc-gh-pczajka
NO-SNOW skip tests of custom requestId on olddriver (#2256)
92cfbc0 
(cherry picked from commit cc563d8)
@sfc-gh-fpawlowski @sfc-gh-pczajka
[Async] Apply #2256 to async code
647a517
@sfc-gh-pczajka
Fix #2227 async implementation
deecc56
sfc-gh-fpawlowski and others added 30 commits November 12, 2025 17:35
@sfc-gh-fpawlowski
SNOW-1675422: add write pandas - part 1. - Added all files related to…
0438d37 
… write_pandas
@sfc-gh-fpawlowski
SNOW-1675422: removed pd_writer utils as those wont work with async i…
cad0229 
…n pandas.to_sql anyway
@sfc-gh-fpawlowski
SNOW-1675422: review fixes
dbcae65
@sfc-gh-fpawlowski
SNOW-1675422: Fixed review fixes - create_temp_table param removed
0176ddb
@sfc-gh-fpawlowski
Linting fix for CI to pass
b151e77
@sfc-gh-fpawlowski
SNOW-2671717: Async connect context manager support - approach 1 - id…
68be308 
…empotent __aenter__ through checking if conn closed (#2614)
@sfc-gh-jwilkowski @sfc-gh-fpawlowski
SNOW-2466332: Do not require user when using OAuth flow (#2606)
8df49a8 
(cherry picked from commit db2a10f)
@sfc-gh-fpawlowski
[async] Applied #2606 to async code
78bde26
@sfc-gh-fpawlowski
Snow 1983343 add timeout for ocsp root certificates (#2559)
770b347 
Co-authored-by: Mikołaj Kubik <mikolaj.kubik@snowflake.com>

(cherry picked from commit b301717)

# Conflicts:
#	src/snowflake/connector/ssl_wrap_socket.py
@sfc-gh-fpawlowski
[async] Applied #2559 to async code
d1caff3
@mathiasflorin @sfc-gh-fpawlowski
Improve AWS region detection by checking AWS_DEFAULT_REGION as fallba…
2a820a1 
…ck (#2535)

Co-authored-by: Patryk Czajka <patryk.czajka@snowflake.com>

(cherry picked from commit ae2bf2e)
@sfc-gh-fpawlowski
[async] Applied #2535 to async code
c85e441
@sfc-gh-gmerticariu @sfc-gh-fpawlowski
SNOW-2161716: Raise error if the config file is writable by others (#…
1220f08 
…2501)

Co-authored-by: Patryk Czajka <patryk.czajka@snowflake.com>

(cherry picked from commit e3349a3)
@sfc-gh-pczajka @sfc-gh-fpawlowski
Bumped up PythonConnector version from 3.17.4 to 4.0.0 (#2561)
9fa18a6 
Co-authored-by: Jenkins User <900904>
Co-authored-by: github-actions <github-actions@github.com>

(cherry picked from commit d6113ba)
@sfc-gh-dszmolka @sfc-gh-fpawlowski
SNOW-2324060 don't attempt non working bucket accelerate endpoint for…
845a582 
… internal stages (#2556)

(cherry picked from commit 7708f1b)
@sfc-gh-fpawlowski
[async] Applied #2556 to async code
764f547
@sfc-gh-pcyrek @sfc-gh-fpawlowski
SNOW-2021009: Improving CICD, flakiness fixes (#2569)
f8baeba 
(cherry picked from commit cfa0ad8)
@sfc-gh-fpawlowski
[async] Applied #2569 to async code
ebc316d
@sfc-gh-pczajka @sfc-gh-fpawlowski
Update DESCRIPTION.md after 3.18.0 release (#2571)
ff5ef48 
(cherry picked from commit 252a5f1)
@sfc-gh-fpawlowski
[async] review changes
f700bf4
@sfc-gh-fpawlowski
[async] commented parts with ocsp revoked certs timeout in tests brok…
5c42992 
…en (reapply #2559)
@sfc-gh-fpawlowski
SNOW-2463378: no_proxy support (#2596)
ffded81 
(cherry picked from commit 9c9be36)
@sfc-gh-fpawlowski
[async] Applied #2596 to async code - part 1
e819f16
@sfc-gh-fpawlowski
[async] Applied #2596 to async code - part 2
bfe223b 
# Conflicts:
#	src/snowflake/connector/aio/_session_manager.py
@sfc-gh-fpawlowski
[async] Applied #2596 to async code - part 3 - basic tests working
5c60a44
@sfc-gh-fpawlowski
[async] Applied #2596 to async code - part 4 - proxies tests working
d9f70f4
@sfc-gh-fpawlowski
[async] review changes
f9c72f8
@sfc-gh-fpawlowski
[async] fix tests
3c2f250
@sfc-gh-fpawlowski
[async] fix tests and missed rebase parts
e2d145b
@sfc-gh-fpawlowski
[async] fix tests and missed rebase parts
a6042c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

DO NOT MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.