Skip to content

Conversation

@sfc-gh-mkubik
Copy link
Contributor

@sfc-gh-mkubik sfc-gh-mkubik commented Mar 20, 2025

Converting two date values: incorrect and correct in this order resulted in cancellation of PyErr_Occurred which led to creation of a table with uninitialised values that caused segmentation fault when accessed from python. This PR breaks the processing right after the error occurred in order to propagate it directly to the driver interface.

addresses issue #2216

@sfc-gh-mkubik sfc-gh-mkubik added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Mar 20, 2025
@sfc-gh-mkubik sfc-gh-mkubik marked this pull request as ready for review March 20, 2025 16:20
@sfc-gh-mkubik sfc-gh-mkubik merged commit 5e96035 into main Mar 28, 2025
91 of 94 checks passed
@sfc-gh-mkubik sfc-gh-mkubik deleted the SNOW-1989239-invalid-date-segfault branch March 28, 2025 13:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
sfc-gh-pczajka added a commit that referenced this pull request Sep 3, 2025
sfc-gh-pczajka added a commit that referenced this pull request Sep 3, 2025
sfc-gh-fpawlowski pushed a commit that referenced this pull request Sep 3, 2025
sfc-gh-pczajka added a commit that referenced this pull request Sep 3, 2025
sfc-gh-pczajka added a commit that referenced this pull request Sep 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants