Skip to content

Conversation

@sfc-gh-jszczerbinski
Copy link
Collaborator

ireallyshouldnotexistatallanywhere.com got registered and returns 200 when testing connection, I am changing the url to one with invalid TLD to fix connection diagnostic and prevent similar issues in the future

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

ireallyshouldnotexistatallanywhere.com got registered and returns 200 when testing connection, I am changing the url to one with invalid TLD to fix connection diagnostic and prevent similar issues in the future
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski added DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md labels Apr 4, 2025
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski merged commit 3a798e8 into main Apr 4, 2025
92 of 96 checks passed
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski deleted the sfc-gh-jszczerbinski-patch-1 branch April 4, 2025 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants