Skip to content

SNOW-1789751: Pass GCS regional and virtual params #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 1, 2025
Merged

SNOW-1789751: Pass GCS regional and virtual params #2241

merged 12 commits into from
Apr 1, 2025
+9 −1

Conversation

@sfc-gh-pbulawa
Copy link
Contributor

@sfc-gh-pbulawa sfc-gh-pbulawa commented Mar 31, 2025

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Pass new parameters to the GCS client

  4. (Optional) PR for stored-proc connector:

@sfc-gh-pbulawa sfc-gh-pbulawa added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Mar 31, 2025
@sfc-gh-pbulawa
Merge remote-tracking branch 'origin/main' into SNOW-1789751-gcp-regi…
dbbebf3 
…on-endpoints

# Conflicts:
#	DESCRIPTION.md
#	src/snowflake/connector/connection.py
#	src/snowflake/connector/gcs_storage_client.py
@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 985ec5e into main Apr 1, 2025
91 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-1789751-gcp-region-endpoints branch April 1, 2025 10:05
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik approved these changes

@sfc-gh-mmishchenko sfc-gh-mmishchenko sfc-gh-mmishchenko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-pbulawa @sfc-gh-mkubik @sfc-gh-mmishchenko