SNOW-2011670 Allow requestId to be set with statement params #2240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-lspiegelberg
requested review from
sfc-gh-aling,
sfc-gh-azwiegincew,
sfc-gh-evandenberg,
sfc-gh-heshah,
sfc-gh-mkubik and
sfc-gh-oplaton
sfc-gh-heshah
approved these changes
Apr 2, 2025
Contributor
sfc-gh-heshah
left a comment
sfc-gh-heshah
left a comment
There was a problem hiding this comment.
Small nit, otherwise LGTM!
sfc-gh-evandenberg
approved these changes
Apr 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2011670
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
As part of the Snowpark IR project, we will send AST as part of the request. To restore them faithfully on the server-side and avoid introducing yet another layer of indirection, we would like to use the HTTP Request Id. Currently, this Request Id is generated on the client as part of issuing the query. With this PR we introduce a new (client-side) statement parameter
requestIdthat allows to overwrite the automatically generated request Id.requestIdmust be avalid UUID4 or UUID4 string.(Optional) PR for stored-proc connector:
to be done when interface here is approved.