Scratch-guiをマージしました #100
Merged
Scratch-guiをマージしました #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the reducer is actually called with the project data that storage loaded
Add project loading HOC tests
* Adjust language icon and caret in menu-bar * remove unused style from `language-selector.css`
Migrate Videos from YouTube
…driver-2.42.1 Update chromedriver to the latest version 🚀
* Look up video id based on locale. * add japanese video ids * add test
… for performance, address other review feedback.
…d-title sb-file-uploader gets title of any sb.* file; calls onUpdateProjectTitle
…h-storage-1.0.5 Update scratch-storage to the latest version 🚀
…h-vm-0.2.0-prerelease.20181017214556 Update scratch-vm to the latest version 🚀
…230-translate-videos Add video translation
…h-vm-0.2.0-prerelease.20181018161118 Update scratch-vm to the latest version 🚀
…l-bugfix Get costume url bugfix
responding to canSave without needing canSaveNew prop removed canSaveNew added default for onUpdateProjectId removed conflict files erroneously added don't pass down onError got tests passing better creating and saving logic and names
…fter language has been switched.
…lerts-locale-switch Resolves scratchfoundation#3336: Prevent multiple peripheral alerts after language switch
…w-project handle many modes of new project creation
This is taking advantage of the fact that react-intl can support nested IntlProviders. GUI will use it’s own ConnectedIntlProvider, that maintains the translations in redux, while www will continue to have it’s own IntlProvider that is initialized when the page loads. Moving the IntlProvider into GUI meant that nothing in the playground can use injectIntl, so the default project name needed to move into the component instead of being in the reducer. The Localization HOC is added, it takes an optional onSetLanguage handler, so www can pass a function that will set the cookie that www needs.
…-typos Fix message typos
…2172-integrate-intl Refactor IntlProvider in GUI to support integration with www
…h-vm-0.2.0-prerelease.20181019092856 Update scratch-vm to the latest version 🚀
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.