Skip to content

Fix block direction in loading animation for RTL #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 19, 2018
Merged

Fix block direction in loading animation for RTL #3316

merged 3 commits into from
Oct 19, 2018

Conversation

@kyleplo
Copy link
Contributor

@kyleplo kyleplo commented Oct 8, 2018

Resolves

Proposed Changes

This pull request flips the direction of the loading blocks on right-to-left languages

Reason for Changes

This makes the blocks not look strange, and also look more like the real RTL blocks.

Test Coverage

image

Browser Coverage

Check the OS/browser combinations tested (At least 2)

Mac

  • Chrome
  • Firefox
  • Safari

Windows

  • Chrome
  • Firefox
  • Edge

Chromebook

  • Chrome

iPad

  • Safari

Android Tablet

  • Chrome

@thisandagain thisandagain added this to the October 2018 milestone Oct 8, 2018
chrisgarrity
chrisgarrity suggested changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@chrisgarrity chrisgarrity left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not working for me (MacOS Chrome). Hopefully this gif captures what's going on. The blocks rotate back to LTR partway through the animation. (sorry I forgot to turn on autorepeat, click the image to see it again)
loading-rtl

You may just need a transform: scaleX(-1) to flip the direction of the block on all the blocks, and leave all the animations as they are.

@chrisgarrity chrisgarrity assigned kyleplo and unassigned chrisgarrity Oct 11, 2018
@kyleplo
Copy link
Contributor Author

kyleplo commented Oct 11, 2018

Should work now

@chrisgarrity chrisgarrity assigned chrisgarrity and unassigned kyleplo Oct 19, 2018
chrisgarrity
chrisgarrity approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@chrisgarrity chrisgarrity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@chrisgarrity chrisgarrity merged commit e810c5e into scratchfoundation:develop Oct 19, 2018
chrisgarrity pushed a commit to chrisgarrity/scratch-gui that referenced this pull request Oct 19, 2018
@kyleplo @chrisgarrity
Fix block direction in loading animation for RTL (scratchfoundation#3316
6fd01d0 
)

* Make loader blocks mirrored on RTL

* Whoops, forgot to change names

* Fix problems with flipping back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chrisgarrity chrisgarrity chrisgarrity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chrisgarrity chrisgarrity

Labels

pr - changes requested

Projects

None yet

Milestone

October 2018

Development

Successfully merging this pull request may close these issues.

3 participants

@kyleplo @chrisgarrity @thisandagain