Add project loading HOC tests #3350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 11, 2018 18:21
This ensures that the reducer is actually called with the project data that storage loaded
benjiwheeler
previously approved these changes
Oct 12, 2018
| onLoadedProject: loadingState => dispatch(onLoadedProject(loadingState)) | ||
| }); | ||
|
|
||
| const mergeProps = (stateProps, dispatchProps, ownProps) => Object.assign( |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Proposed Changes
Describe what this Pull Request does
Adds tests for some of the new higher order components added in #3303
Reason for Changes
Explain why these changes should be made
We should make sure the things we add work the way we expect
Test Coverage
Please show how you have added tests to cover your changes
These are tests!
Browser Coverage
N/A