User can load new project in 3.0 #3303
Conversation
|
Tests seem to be failing because of this #3305 |
|
One thought: I think we could get similar functionality to the state machine from a set of booleans managed in the project-id reducer (or whatever we end up calling it). Not positive if it would feel cleaner, but if it worked, the interface to the components could be essentially the same, but the inner workings of the reducer would be more familiar to other developers, and it would be more redux-y. |
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
I have reviewed about half of this. But just want to get these comments published before the end of the day.
…of code to fetch title from api
…s also default one, then it loads new project twice
|
This is in good shape now, I think! The big outstanding issue are the tests. |
benjiwheeler
force-pushed
the
new-project
branch
from
48fefb9 to
515102d
Compare
benjiwheeler
force-pushed
the
new-project
branch
from
515102d to
ed4c063
Compare
stripped title handling from sb file uploader updated more projectState related names simplified hash-parser-hoc logic slightly
benjiwheeler
force-pushed
the
new-project
branch
from
ed4c063 to
91028a0
Compare
| const loadingState = state.scratchGui.projectState.loadingState; | ||
| const user = state.session && state.session.session && state.session.session.user; | ||
| return { | ||
| accountMenuOpen: accountMenuOpen(state), |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
src/components/menu-bar/menu-bar.jsx
Outdated
| onRequestCloseLogin: () => dispatch(closeLoginMenu()), | ||
| onSeeCommunity: () => dispatch(setPlayer(true)) | ||
| onClickNew: canSave => dispatch(newProjectRequested(canSave)), | ||
| onClickSave: () => dispatch(saveRequested()), |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
webpack.config.js
Outdated
| }, | ||
| plugins: base.plugins.concat([ | ||
| new webpack.DefinePlugin({ | ||
| 'process.env.API_HOST': '"' + process.env.API_HOST + '"', |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
3 participants
Resolves
#2954
Proposed Changes
Introduces support for loading a new project, in both playground/standalone player and embedded/login-able modes.
Currently uses a state machine to manage where in the project loading and displaying lifecycle we currently are.
Reason for Changes
Users need to be able to create new projects from within the editor.
Test Coverage
None yet.
Browser Coverage
Mac
Windows
Chromebook
iPad
Android Tablet