sb-file-uploader gets title of any sb.* file; calls onUpdateProjectTitle #3379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@rschamp any suggestions for how to write tests for this? Seems like it's tricky to do it without opening the OS filepicker... |
rschamp
suggested changes
Oct 16, 2018
Contributor
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
I think the best way to test these changes specifically would be to add unit tests for the HOC and break up the methods a bit so you could test the matcher in isolation from everything else.
Supposedly you can use sendKeys to have selenium interact with a file input: https://stackoverflow.com/questions/13963738/how-does-selenium-webdriver-upload-files-to-the-browser
… title from .sb2 and .sb3 filenames
benjiwheeler
force-pushed
the
set-upload-title
branch
from
651d635 to
76e11e0
Compare
Contributor
Author
|
Take a look. I didn't mock up the filepicker input, just made unit tests of the filename extraction. It's a start! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #3339 and #3140 and #3357
Proposed Changes
Handles/shows title of a 2.0 project (and will work for 1.0 projects, and projects missing extension, if it needs to) when one is loaded in 3.0.
calls the onUpdateProjectTitle passed to it from
MenuBarwith the new title, if it exists. This allows code that encloses or embeds GUI to be notified of the title change when a file is uploaded.Reason for Changes
Test Coverage
None. Unclear how to test this well?
Browser Coverage
tested in Mac Chrome