Skip to content

Implement representation options to smir #141942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

Implement representation options to smir #141942

merged 1 commit into from
Jun 11, 2025
+132 −6

Conversation

ShoyuVanilla
Copy link
Member

@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2025
@ShoyuVanilla
Copy link
Member Author

Oh, it seems that rustbot randomly assigns reviewer instead of code owners. Sorry 😅

r? @celinval

@rustbot rustbot assigned celinval and unassigned scottmcm Jun 3, 2025
celinval
celinval reviewed Jun 3, 2025
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Can you please add a test? Thanks

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ShoyuVanilla ShoyuVanilla force-pushed the smir-repr branch 2 times, most recently from 029062d to 56c16f9 Compare June 3, 2025 15:52
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ShoyuVanilla ShoyuVanilla requested a review from celinval June 3, 2025 18:07
oli-obk
oli-obk reviewed Jun 10, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jun 10, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jun 10, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jun 10, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jun 10, 2025
View reviewed changes
@oli-obk
Copy link
Contributor

oli-obk commented Jun 10, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 10, 2025

📌 Commit dabed33 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2025
@fmease fmease mentioned this pull request Jun 10, 2025
Closed
bors added a commit that referenced this pull request Jun 11, 2025
@bors
Auto merge of #142313 - fmease:rollup-lktx4uz, r=fmease
114fc69 
Rollup of 13 pull requests

Successful merges:

 - #128425 (Make `missing_fragment_specifier` an unconditional error)
 - #141639 (Expose discriminant values in stable_mir)
 - #141967 (Configure bootstrap backport nominations through triagebot)
 - #142042 (Make E0621 missing lifetime suggestion verbose)
 - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
 - #142235 (Build rustc with assertions in `dist-alt` jobs)
 - #142248 (Add supported asm types for LoongArch32)
 - #142272 (tests: Change ABIs in tests to more future-resilient ones)
 - #142282 (Only run `citool` tests on the `auto` branch)
 - #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats)
 - #142297 (Implement `//@ needs-target-std` compiletest directive)
 - #142298 (Make loongarch-none target maintainers more easily pingable)
 - #142306 (Dont unwrap and re-wrap typing envs)

Failed merges:

 - #141942 (Implement representation options to smir)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee workingjubilee mentioned this pull request Jun 11, 2025
Closed
@workingjubilee
Copy link
Member

@bors rollup=iffy

@bors
Copy link
Collaborator

bors commented Jun 11, 2025

⌛ Testing commit dabed33 with merge 0a39445...

@bors
Copy link
Collaborator

bors commented Jun 11, 2025

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 0a39445 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 11, 2025
@bors bors merged commit 0a39445 into rust-lang:master Jun 11, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 11, 2025
@ShoyuVanilla ShoyuVanilla deleted the smir-repr branch June 11, 2025 11:46
@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2b0274c (parent) -> 0a39445 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 0a39445252ac076ef573bcacee63bbdc59497b52 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 9159.1s -> 13442.3s (46.8%)
  2. mingw-check-1: 1968.4s -> 1611.3s (-18.1%)
  3. dist-aarch64-apple: 6470.8s -> 5558.2s (-14.1%)
  4. i686-gnu-2: 6192.5s -> 5378.4s (-13.1%)
  5. i686-gnu-1: 8247.0s -> 7210.6s (-12.6%)
  6. aarch64-gnu-debug: 4179.1s -> 3710.0s (-11.2%)
  7. armhf-gnu: 5021.3s -> 4496.5s (-10.5%)
  8. mingw-check-tidy: 66.6s -> 73.1s (9.7%)
  9. x86_64-gnu-llvm-19-1: 3611.0s -> 3309.1s (-8.4%)
  10. dist-armv7-linux: 4978.3s -> 5391.9s (8.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Jun 11, 2025
Open
Open
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0a39445): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.4%, secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.4% [-6.0%, -0.8%] 22
Improvements ✅
(secondary)		 -2.7% [-9.3%, -0.7%] 79
All ❌✅ (primary) -2.4% [-6.0%, -0.8%] 22

Cycles

Results (secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 754.155s -> 754.356s (0.03%)
Artifact size: 372.17 MiB -> 372.07 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

@celinval celinval Awaiting requested review from celinval

Assignees

@celinval celinval

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

Add information about Adt representation
9 participants
@ShoyuVanilla @rustbot @rust-log-analyzer @oli-obk @bors @workingjubilee @rust-timer @celinval @scottmcm