Build rustc with assertions in dist-alt jobs
#142235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Some changes occurred in src/tools/opt-dist cc @Kobzol |
|
@bors2 try |
rust-bors bot
added a commit
that referenced
this pull request
Jun 9, 2025
Rustc dist alt assertions Revival of #131077, to check CI times now that we don't do PGO/BOLT anymore on Linux `-alt` builds. r? `@ghost` try-job: dist-x86_64-msvc-alt try-job: dist-x86_64-linux-alt
Kobzol
changed the title
dist-alt jobs
|
@bors2 try |
rust-bors bot
added a commit
that referenced
this pull request
Jun 9, 2025
Build rustc with assertions in `dist-alt` jobs Revival of #131077, to check CI times now that we don't do PGO/BOLT anymore on Linux `-alt` builds. r? `@ghost` try-job: dist-x86_64-msvc-alt try-job: dist-x86_64-linux-alt
|
2h 14 minutes with the 8-core runner, pretty nice. @marcoieni would you be fine to switch the |
marcoieni
reviewed
Jun 9, 2025
yes it's fine 👍 |
llvm assertions are already enabled and debug assertions are also useful
Kobzol
force-pushed
the
rustc-dist-alt-assertions
branch
from
6d4df2d to
607a567
Compare
|
@bors2 try |
rust-bors bot
added a commit
that referenced
this pull request
Jun 10, 2025
Build rustc with assertions in `dist-alt` jobs Revival of #131077, to check CI times now that we don't do PGO/BOLT anymore on Linux `-alt` builds. r? `@ghost` try-job: dist-x86_64-msvc-alt try-job: dist-x86_64-linux-alt
|
r? @marcoieni |
|
@bors r+ |
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
Jun 10, 2025
…r=marcoieni Build rustc with assertions in `dist-alt` jobs Revival of rust-lang#131077, to check CI times now that we don't do PGO/BOLT anymore on Linux `-alt` builds. r? `@ghost` try-job: dist-x86_64-msvc-alt try-job: dist-x86_64-linux-alt
bors
added a commit
that referenced
this pull request
Jun 11, 2025
Rollup of 13 pull requests Successful merges: - #128425 (Make `missing_fragment_specifier` an unconditional error) - #141639 (Expose discriminant values in stable_mir) - #141967 (Configure bootstrap backport nominations through triagebot) - #142042 (Make E0621 missing lifetime suggestion verbose) - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - #142235 (Build rustc with assertions in `dist-alt` jobs) - #142248 (Add supported asm types for LoongArch32) - #142272 (tests: Change ABIs in tests to more future-resilient ones) - #142282 (Only run `citool` tests on the `auto` branch) - #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats) - #142297 (Implement `//@ needs-target-std` compiletest directive) - #142298 (Make loongarch-none target maintainers more easily pingable) - #142306 (Dont unwrap and re-wrap typing envs) Failed merges: - #141942 (Implement representation options to smir) r? `@ghost` `@rustbot` modify labels: rollup
|
sorry, I don't have a good reason, it just has a vibe, and I think everyone else is assuming it does too. @bors rollup=iffy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revival of #131077, to check CI times now that we don't do PGO/BOLT anymore on Linux
-altbuilds.r? @ghost
try-job: dist-x86_64-msvc-alt
try-job: dist-x86_64-linux-alt