Add supported asm types for LoongArch32 by heiher · Pull Request #142248 · rust-lang/rust

heiher · 2025-06-09T15:05:45Z

compiler-errors · 2025-06-09T16:29:47Z

compiler/rustc_target/src/asm/loongarch.rs

        match self {
-            Self::reg => types! { _: I8, I16, I32, I64, F32, F64; },
+            Self::reg => {
+                if arch == InlineAsmArch::LoongArch64 {


should we make this an exhaustive match?

compiler-errors · 2025-06-09T16:30:53Z

src/doc/unstable-book/src/language-features/asm-experimental-arch.md

 | SPARC        | `reg`                           | None           | `i8`, `i16`, `i32`, `i64` (SPARC64 only) |
 | SPARC        | `yreg`                          | N/A            | Only clobbers                           |
+| LoongArch32  | `reg`                           | None           | `i8`, `i16`, `i32`, `f32`               |
+| LoongArch32  | `freg`                          | None           | `f32`, `f64`                            |


The code above reference LoongArch64 but this table doesn't. Is that a mistake?

Could you also add LoongArch32 to the table above?

The code above reference LoongArch64 but this table doesn't. Is that a mistake?

LoongArch64 assembly is already stable. This PR adds it for LoongArch32.

tgross35 · 2025-06-09T23:27:09Z

compiler/rustc_target/src/asm/loongarch.rs

+                    types! { _: I8, I16, I32, I64, F32, F64; }
+                } else {
+                    types! { _: I8, I16, I32, F32; }


Not something to do here, but as a note f16 could probably get allowed in GPRs at some point (maybe also fregs? Not sure what the ABI status is), cc #125398.

I'll submit a separate PR to add support for types like f16 for both LoongArch32 and LoongArch64.

Amanieu · 2025-06-10T10:04:42Z

compiler/rustc_target/src/asm/loongarch.rs

+            (Self::reg, InlineAsmArch::LoongArch64) => types! { _: I8, I16, I32, I64, F32, F64; },
+            (Self::reg, InlineAsmArch::LoongArch32) => types! { _: I8, I16, I32, F32; },
+            (Self::freg, _) => types! { f: F32; d: F64; },
+            _ => unimplemented!("unsupported register class"),


This should be unreachable! instead of unimplemented!.

Amanieu · 2025-06-10T11:13:12Z

@bors r+ rollup

bors · 2025-06-10T11:13:14Z

📌 Commit de8a91b has been approved by Amanieu

It is now in the queue for this repository.

Add supported asm types for LoongArch32 r? `@Amanieu`

Rollup of 13 pull requests Successful merges: - #128425 (Make `missing_fragment_specifier` an unconditional error) - #141639 (Expose discriminant values in stable_mir) - #141967 (Configure bootstrap backport nominations through triagebot) - #142042 (Make E0621 missing lifetime suggestion verbose) - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - #142235 (Build rustc with assertions in `dist-alt` jobs) - #142248 (Add supported asm types for LoongArch32) - #142272 (tests: Change ABIs in tests to more future-resilient ones) - #142282 (Only run `citool` tests on the `auto` branch) - #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats) - #142297 (Implement `//@ needs-target-std` compiletest directive) - #142298 (Make loongarch-none target maintainers more easily pingable) - #142306 (Dont unwrap and re-wrap typing envs) Failed merges: - #141942 (Implement representation options to smir) r? `@ghost` `@rustbot` modify labels: rollup

Add supported asm types for LoongArch32 r? ``@Amanieu``

Add supported asm types for LoongArch32 r? ```@Amanieu```

Rollup of 13 pull requests Successful merges: - #134841 (Look at proc-macro attributes when encountering unknown attribute) - #141639 (Expose discriminant values in stable_mir) - #141967 (Configure bootstrap backport nominations through triagebot) - #142042 (Make E0621 missing lifetime suggestion verbose) - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - #142248 (Add supported asm types for LoongArch32) - #142272 (tests: Change ABIs in tests to more future-resilient ones) - #142282 (Only run `citool` tests on the `auto` branch) - #142297 (Implement `//@ needs-target-std` compiletest directive) - #142298 (Make loongarch-none target maintainers more easily pingable) - #142306 (Dont unwrap and re-wrap typing envs) - #142324 (Remove unneeded `FunctionCx` from some codegen methods) - #142328 (feat: Add `bit_width` for unsigned integer types) r? `@ghost` `@rustbot` modify labels: rollup

Add supported asm types for LoongArch32 r? ````@Amanieu````

Add supported asm types for LoongArch32 r? `````@Amanieu`````

Rollup of 9 pull requests Successful merges: - #128425 (Make `missing_fragment_specifier` an unconditional error) - #135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features) - #140770 (add `extern "custom"` functions) - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - #142248 (Add supported asm types for LoongArch32) - #142267 (assert more in release in `rustc_ast_lowering`) - #142274 (Update the stdarch submodule) - #142276 (Update dependencies in `library/Cargo.lock`) - #142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library) Failed merges: - #140920 (Extract some shared code from codegen backend target feature handling) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various

Rollup merge of #142248 - heiher:loong32-asm-types, r=Amanieu Add supported asm types for LoongArch32 r? ``````@Amanieu``````

Rollup of 9 pull requests Successful merges: - rust-lang/rust#128425 (Make `missing_fragment_specifier` an unconditional error) - rust-lang/rust#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features) - rust-lang/rust#140770 (add `extern "custom"` functions) - rust-lang/rust#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - rust-lang/rust#142248 (Add supported asm types for LoongArch32) - rust-lang/rust#142267 (assert more in release in `rustc_ast_lowering`) - rust-lang/rust#142274 (Update the stdarch submodule) - rust-lang/rust#142276 (Update dependencies in `library/Cargo.lock`) - rust-lang/rust#142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library) Failed merges: - rust-lang/rust#140920 (Extract some shared code from codegen backend target feature handling) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#128425 (Make `missing_fragment_specifier` an unconditional error) - rust-lang#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features) - rust-lang#140770 (add `extern "custom"` functions) - rust-lang#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - rust-lang#142248 (Add supported asm types for LoongArch32) - rust-lang#142267 (assert more in release in `rustc_ast_lowering`) - rust-lang#142274 (Update the stdarch submodule) - rust-lang#142276 (Update dependencies in `library/Cargo.lock`) - rust-lang#142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library) Failed merges: - rust-lang#140920 (Extract some shared code from codegen backend target feature handling) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various

Rollup of 9 pull requests Successful merges: - rust-lang/rust#128425 (Make `missing_fragment_specifier` an unconditional error) - rust-lang/rust#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features) - rust-lang/rust#140770 (add `extern "custom"` functions) - rust-lang/rust#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - rust-lang/rust#142248 (Add supported asm types for LoongArch32) - rust-lang/rust#142267 (assert more in release in `rustc_ast_lowering`) - rust-lang/rust#142274 (Update the stdarch submodule) - rust-lang/rust#142276 (Update dependencies in `library/Cargo.lock`) - rust-lang/rust#142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library) Failed merges: - rust-lang/rust#140920 (Extract some shared code from codegen backend target feature handling) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various

rustbot assigned Amanieu Jun 9, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 9, 2025

compiler-errors reviewed Jun 9, 2025

View reviewed changes

tgross35 reviewed Jun 9, 2025

View reviewed changes

heiher force-pushed the loong32-asm-types branch from 55cfa4b to 28c06c4 Compare June 10, 2025 03:19

Amanieu reviewed Jun 10, 2025

View reviewed changes

heiher force-pushed the loong32-asm-types branch from 28c06c4 to de8a91b Compare June 10, 2025 10:49

Add supported asm types for LoongArch32

de8a91b

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2025

fmease added a commit to fmease/rust that referenced this pull request Jun 10, 2025

Rollup merge of rust-lang#142248 - heiher:loong32-asm-types, r=Amanieu

89a1c7a

Add supported asm types for LoongArch32 r? `@Amanieu`

fmease mentioned this pull request Jun 10, 2025

Rollup of 13 pull requests #142313

Closed

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 11, 2025

Rollup merge of rust-lang#142248 - heiher:loong32-asm-types, r=Amanieu

9494235

Add supported asm types for LoongArch32 r? ``@Amanieu``

workingjubilee mentioned this pull request Jun 11, 2025

Rollup of 17 pull requests #142332

Closed

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 11, 2025

Rollup merge of rust-lang#142248 - heiher:loong32-asm-types, r=Amanieu

74fbf92

Add supported asm types for LoongArch32 r? ```@Amanieu```

workingjubilee mentioned this pull request Jun 11, 2025

Rollup of 13 pull requests #142333

Closed

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 12, 2025

Rollup merge of rust-lang#142248 - heiher:loong32-asm-types, r=Amanieu

1be2954

Add supported asm types for LoongArch32 r? ````@Amanieu````

workingjubilee mentioned this pull request Jun 12, 2025

Rollup of 15 pull requests #142396

Closed

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 12, 2025

Rollup merge of rust-lang#142248 - heiher:loong32-asm-types, r=Amanieu

b6bed38

Add supported asm types for LoongArch32 r? `````@Amanieu`````

workingjubilee mentioned this pull request Jun 12, 2025

Rollup of 15 pull requests #142397

Closed

matthiaskrgr mentioned this pull request Jun 13, 2025

Rollup of 9 pull requests #142443

Merged

bors merged commit f6b02bb into rust-lang:master Jun 13, 2025
10 checks passed

rustbot added this to the 1.89.0 milestone Jun 13, 2025

rust-timer added a commit that referenced this pull request Jun 13, 2025

Unrolled build for #142248

c92c6df

Rollup merge of #142248 - heiher:loong32-asm-types, r=Amanieu Add supported asm types for LoongArch32 r? ``````@Amanieu``````

heiher deleted the loong32-asm-types branch June 13, 2025 21:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add supported asm types for LoongArch32#142248

Add supported asm types for LoongArch32#142248
bors merged 1 commit intorust-lang:masterfrom
heiher:loong32-asm-types

heiher commented Jun 9, 2025

Uh oh!

compiler-errors Jun 9, 2025

Uh oh!

heiher Jun 10, 2025

Uh oh!

compiler-errors Jun 9, 2025

Uh oh!

Amanieu Jun 9, 2025

Uh oh!

heiher Jun 10, 2025

Uh oh!

tgross35 Jun 9, 2025

Uh oh!

heiher Jun 10, 2025

Uh oh!

Amanieu Jun 10, 2025

Uh oh!

Amanieu commented Jun 10, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

heiher commented Jun 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Amanieu commented Jun 10, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants