Per controller update rate without tests #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmagyar
requested review from
bmagyar,
destogl and
jordan-palacios
and removed request for
destogl
destogl
requested changes
Sep 6, 2021
controller_interface/include/controller_interface/controller_interface.hpp
Outdated
Show resolved
Hide resolved
controller_manager/include/controller_manager/controller_manager.hpp
Outdated
Show resolved
Hide resolved
VX792
force-pushed
the
per-controller-without-tests
branch
4 times, most recently
from
6c2dbc0 to
3ce0cbe
Compare
destogl
reviewed
Sep 13, 2021
controller_interface/include/controller_interface/controller_interface.hpp
Outdated
Show resolved
Hide resolved
bmagyar
changed the title
12 tasks
…nter minor corrections after rebase minor rebase corrections #2 minor rebase corrections ros-controls#3
… for the update rate variables
VX792
force-pushed
the
per-controller-without-tests
branch
from
3ce0cbe to
4301158
Compare
… controller's update rate doesn't match the cm's
VX792
force-pushed
the
per-controller-without-tests
branch
from
4301158 to
b3262b5
Compare
bmagyar
reviewed
Sep 22, 2021
VX792
force-pushed
the
per-controller-without-tests
branch
from
c07a68b to
d4bc496
Compare
…is undefined, and make precommit happy
VX792
force-pushed
the
per-controller-without-tests
branch
from
d4bc496 to
9cd95a7
Compare
VX792
force-pushed
the
per-controller-without-tests
branch
from
c8a49bf to
6d37e84
Compare
destogl
reviewed
Sep 24, 2021
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
destogl
reviewed
Sep 24, 2021
bmagyar
approved these changes
Sep 24, 2021
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
destogl
reviewed
Sep 24, 2021
destogl
reviewed
Sep 24, 2021
destogl
approved these changes
Sep 24, 2021
Member
destogl
left a comment
destogl
left a comment
There was a problem hiding this comment.
Please address this comment and we are OK :)
Thanks!
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per controller update rate stuff that we were looking into with Bence. Hopefully I did everything correctly and nothing was lost when I was resolving the merge conflicts. (hey it compiles!)
I plan on opening a separate pull request for the tests of this task, but those are still very work-in-progress.