Skip to content

Conversation

@wmmc88
Copy link
Contributor

@wmmc88 wmmc88 commented Dec 2, 2021

I was previously getting the following compile error on Windows using Rolling:

controller_manager.obj : error LNK2019: unresolved external symbol "public: unsigned int __cdecl controller_interface::ControllerInterface::get_update_rate(void)const " (?get_update_rate@ControllerInterface@controller_interface@@QEBAIXZ) referenced in function "public: enum controller_interface::return_type __cdecl controller_manager::ControllerManager::update(class rclcpp::Time const &,class rclcpp::Duration const &)" (?update@ControllerManager@controller_manager@@QEAA?AW4return_type@controller_interface@@AEBVTime@rclcpp@@AEBVDuration@6@@Z) [C:\Users\melvi\git-repos\uwrt_ros2_ws\build\controller_manager\controller_manager.vcxproj]
C:\Users\melvi\git-repos\uwrt_ros2_ws\build\controller_manager\Release\controller_manager.dll : fatal error LNK1120: 1 unresolved externals [C:\Users\melvi\git-repos\uwrt_ros2_ws\build\controller_manager\controller_manager.vcxproj]

Looks like it was probably introduced in #513 .

my ws uses the following ros2_control.repos:

repositories:
  ros-controls/ros2_control:
    type: git
    url: https://github.com/ros-controls/ros2_control.git
    version: galactic
  ros-controls/ros2_controllers:
    type: git
    url: https://github.com/ros-controls/ros2_controllers.git
    version: master
  ros-controls/realtime_tools:
    type: git
    url: https://github.com/ros-controls/realtime_tools.git
    version: ros2_devel
  ros-controls/control_msgs:
    type: git
    url: https://github.com/ros-controls/control_msgs.git
    version: galactic-devel
  angles:
    type: git
    url: https://github.com/ros/angles.git
    version: ros2

Sidenote: Should https://github.com/ros-controls/ros2_control/blob/galactic/ros2_control/ros2_control.repos be updated to point to galactic, instead of what its currently pointing to (ie. master(ros2_control) and foxy-devel(control_msgs))?

@bmagyar bmagyar merged commit 3f4a55b into ros-controls:master Dec 3, 2021
@bmagyar
Copy link
Member

bmagyar commented Dec 3, 2021

@Mergifyio backport to galactic

mergify bot pushed a commit that referenced this pull request Dec 3, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2021

backport to galactic

✅ Backports have been created

destogl pushed a commit that referenced this pull request Dec 3, 2021
(cherry picked from commit 3f4a55b)

Co-authored-by: Melvin Wang <melvin.mc.wang@gmail.com>
destogl pushed a commit to destogl/ros2_control that referenced this pull request Dec 3, 2021
@wmmc88 wmmc88 deleted the wmmc88/fix-visibility-headers-get-update-rate branch December 3, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants