fix: Move all `aten` PRs to Dynamo converter registry #2070

gs-olive · 2023-06-30T01:14:07Z

Description

The below are now squashed

The structure of this PR is as follows:

The first commit is a squashed set of 16 PRs which add aten improvements and converters, from existing PRs with the label Story: ATen Op Support
The second commit reverts all of the changes to py/torch_tensorrt/fx
The third commit contains all of the changes made to py/torch_tensorrt/fx, replayed on py/torch_tensorrt/dynamo, with required import, reference, and code updates. This sometimes includes code duplication where absolutely necessary to add some new functionality
Subsequent commits add various improvements or modifications to these converters

Fixes #2068

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

[ x ] My code follows the style guidelines of this project (You can use the linters)
[ x ] I have performed a self-review of my own code
[ x ] I have commented my code, particularly in hard-to-understand areas and hacks
[ x ] I have made corresponding changes to the documentation
[ - ] I have added tests to verify my fix or my feature
- Each PR has its own tests
[ x ] New and existing unit tests pass locally with my changes
[ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

.circleci/config.yml

narendasan · 2023-06-30T18:23:28Z

py/torch_tensorrt/dynamo/converters/aten_ops_converters.py

+    }
+    rounding_mode = kwargs.get("rounding_mode")
+    if rounding_mode is None:
+        return acc_ops_converters.acc_ops_div(network, target, None, kwargs_new, name)


why are we calling out to acc_ops here?

Since there was a change to this operator in the trunc_div PR #1869, we need to copy the entire converter to ensure the changes are reflected

py/torch_tensorrt/dynamo/converters/aten_ops_converters.py

py/torch_tensorrt/dynamo/converters/converter_utils.py

py/torch_tensorrt/dynamo/converters/impl/activation.py

py/torch_tensorrt/dynamo/converters/impl/__init__.py

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

refactor: Moving elementwise and unary core to impl Signed-off-by: Naren Dasan <naren@narendasan.com> new file: ../converters/impl/unary/base.py Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905) Converter reorg fmod Converter reorg and rsub Rsub error fixes and linting error fixed Rsub test case to include different inputs Converter reorg batch norm batch norm error fix and linting issue error fix layer_norm converter Layer norm linting correction ops file correction fixing lint Acc_ops layer_norm correction Converter reorg and softmax operation softmax linting error fix Converter reorg and gelu Linting error Converter reorg and squeeze operator Correcting squeeze operator implementation, linting error and acc squeeze test Adding the condition to convert dim to int and removing the comment Converter reorg and select operation select operation correction and linting changes converter reorg and slice converter reorg slice op Correcting linting error and slice changes Correcting the slice operation converter reorg and matmul Matmul issue fixes and lint error check moving matmul to individual file Converter reorg and where operator adding where aten op aten::where correction and linting error changes aten::unsqueeze impl refactor Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Moved clamp to impl Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> fixed method name Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> fix: Add automatic type promotion for FX ops - Implement functionality to cast tensors to alternative types - Add functionality to elementwise ops to promote types and perform necessary casts - Address issues in FX ops where mixed-precision computations can cause errors - Add test cases to validate fix Revert all changes to py/torch_tensorrt/fx Revert "fix: Add automatic type promotion for FX ops" This reverts commit f1f3716. Revert "Moved clamp to impl" This reverts commit df401dd. Revert "aten::unsqueeze impl refactor" This reverts commit b424735. Revert "Converter reorg and where operator" This reverts commit b4da15e. Revert "converter reorg and matmul" This reverts commit 7551eee. Revert "converter reorg and slice" This reverts commit 9bbdc9e. Revert "Converter reorg and select operation" This reverts commit fb70253. Revert "Converter reorg and squeeze operator" This reverts commit 294545c. Revert "Converter reorg and gelu" This reverts commit 37d1168. Revert "Converter reorg and softmax operation" This reverts commit 1ba6d13. Revert "layer_norm converter" This reverts commit e0b34b1. Revert "Converter reorg batch norm" This reverts commit 59354e5. Revert "Converter reorg and rsub" This reverts commit db15d27. Revert "Converter reorg fmod" This reverts commit ce3fa67. Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)" This reverts commit 7158ca5. Revert "refactor: Moving elementwise and unary core to impl" This reverts commit 45e43ca. fix: Replay all FX changes in Dynamo - Add multiple fixes to make FX changes appear in Dynamo directory, using Dynamo registry - All converters with open PRs are linked and shown - Update references, imports, code, merges, rebases accordingly - Add new test cases to Dynamo for converters Temporarily removing rsub pending fix Fixing clamp to not use Torch Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Fixing select to not use torch fix: Reorganize folders in latest implementation - Update test references and imports accordingly Embedding operator in dynamo reciprocal lowering pass fix: Fix for Dynamic Shape Tests + Input class feat: Add permute operation implementation chore: Move converter registry, update imports

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

narendasan

LGTM

gs-olive added Story: ATen Op Support component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 30, 2023

gs-olive requested a review from apbose June 30, 2023 01:14

gs-olive self-assigned this Jun 30, 2023

facebook-github-bot added the cla signed label Jun 30, 2023

github-actions bot added the component: api [Python] Issues re: Python API label Jun 30, 2023

github-actions bot requested a review from narendasan June 30, 2023 01:14

github-actions bot approved these changes Jun 30, 2023

View reviewed changes

gs-olive force-pushed the dynamo_latest branch from c903ed6 to 4690c1a Compare June 30, 2023 02:09

github-actions bot approved these changes Jun 30, 2023

View reviewed changes

gs-olive added the WIP Work is in progress, pull request should not be merged yet label Jun 30, 2023

gs-olive marked this pull request as ready for review June 30, 2023 03:47

github-actions bot approved these changes Jun 30, 2023

View reviewed changes

gs-olive force-pushed the dynamo_latest branch from 4690c1a to 6ae66b1 Compare June 30, 2023 16:15

github-actions bot approved these changes Jun 30, 2023

View reviewed changes

gs-olive force-pushed the dynamo_latest branch from 6ae66b1 to 768417a Compare June 30, 2023 17:26

github-actions bot approved these changes Jun 30, 2023

View reviewed changes

narendasan reviewed Jun 30, 2023

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

narendasan reviewed Jun 30, 2023

View reviewed changes

py/torch_tensorrt/dynamo/converters/aten_ops_converters.py Outdated Show resolved Hide resolved

narendasan reviewed Jun 30, 2023

View reviewed changes

py/torch_tensorrt/dynamo/converters/converter_utils.py Outdated Show resolved Hide resolved

gs-olive commented Jun 30, 2023

View reviewed changes

py/torch_tensorrt/dynamo/converters/impl/activation.py Outdated Show resolved Hide resolved

gs-olive commented Jun 30, 2023

View reviewed changes

py/torch_tensorrt/dynamo/converters/impl/__init__.py Outdated Show resolved Hide resolved

github-actions bot approved these changes Jul 21, 2023

View reviewed changes

Base automatically changed from dynamo_compile_64bit_support to main July 24, 2023 21:41

gs-olive force-pushed the dynamo_latest branch from 2d71f12 to 7d9705d Compare July 24, 2023 22:48

github-actions bot approved these changes Jul 24, 2023

View reviewed changes

gs-olive mentioned this pull request Jul 25, 2023

✨[Feature] Parallelize Dynamo Converter, Backend, E2E Tests in CI #2139

Closed

gs-olive force-pushed the dynamo_latest branch from 7d9705d to e99e1ae Compare July 25, 2023 01:25

github-actions bot approved these changes Jul 25, 2023

View reviewed changes

gs-olive removed the WIP Work is in progress, pull request should not be merged yet label Jul 25, 2023

apbose approved these changes Jul 25, 2023

View reviewed changes

github-actions bot approved these changes Jul 25, 2023

View reviewed changes

gs-olive requested a review from narendasan July 25, 2023 18:09

github-actions bot approved these changes Jul 25, 2023

View reviewed changes

gs-olive force-pushed the dynamo_latest branch from b576f30 to e7267a1 Compare July 25, 2023 18:16

github-actions bot approved these changes Jul 25, 2023

View reviewed changes

narendasan approved these changes Jul 25, 2023

View reviewed changes

narendasan merged commit aeadd72 into main Jul 25, 2023

narendasan deleted the dynamo_latest branch July 25, 2023 23:50

This was referenced Jul 28, 2023

Moving normalization core to impl - softmax (FX Converter Refactor [12/N]) <Target: converter_reorg_elementwise> #1909

Closed

✨[Converter] Implement aten::embedding #1797

Closed

narendasan mentioned this pull request Aug 1, 2023

fix: Add automatic type promotion for FX elementwise ops #2055

Closed

gs-olive mentioned this pull request Aug 2, 2023

Moving permute core to impl - permute(FX Converter Refactor [22/N]) <Target: converter_reorg_elementwise> #1999

Closed

7 tasks

gs-olive mentioned this pull request Sep 8, 2023

🐛 [Bug] Encountered bug when compiling fasterrcnn_mobilenet_v3_large_320_fpn in Dynamo #1995

Closed

gs-olive mentioned this pull request Sep 19, 2023

✨[Feature] Automatic type promotion for elementwise ops in FX #2031

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Move all `aten` PRs to Dynamo converter registry #2070

fix: Move all `aten` PRs to Dynamo converter registry #2070

gs-olive commented Jun 30, 2023 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

narendasan Jun 30, 2023

gs-olive Jun 30, 2023

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

narendasan left a comment

fix: Move all aten PRs to Dynamo converter registry #2070

fix: Move all aten PRs to Dynamo converter registry #2070

Conversation

gs-olive commented Jun 30, 2023 • edited Loading

Description

Type of change

Checklist:

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

narendasan Jun 30, 2023

Choose a reason for hiding this comment

gs-olive Jun 30, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

narendasan left a comment

Choose a reason for hiding this comment

fix: Move all `aten` PRs to Dynamo converter registry #2070

fix: Move all `aten` PRs to Dynamo converter registry #2070

gs-olive commented Jun 30, 2023 •

edited

Loading