refactor: Moving elementwise core to impl (FX Converter Refactor [3/N]) <Target: converter_reorg_proto> #1869

narendasan · 2023-04-28T23:44:15Z

Description

Moves Elementwise and Unary core functions to impl in preparation for moving other ops

Type of change

Please delete options that are not relevant and/or add your own.

Refactor

Checklist:

My code follows the style guidelines of this project (You can use the linters)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas and hacks
I have made corresponding changes to the documentation
I have added tests to verify my fix or my feature
New and existing unit tests pass locally with my changes
I have added the relevant labels to my PR in so that relevant reviewers are notified

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

narendasan · 2023-05-20T23:43:04Z

@wushirong Can you review this PR. This is gating release of 1.4

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

Signed-off-by: Naren Dasan <naren@narendasan.com> new file: ../converters/impl/unary/base.py

… <Target: converter_reorg_elementwise> (#1905)

…_converter and adding convolution in acc_ops_converters.py and aten_ops_converters.py

narendasan · 2023-07-17T19:53:20Z

Closing in favor of #2070

facebook-github-bot added cla signed fx labels Apr 28, 2023

github-actions bot added component: api [Python] Issues re: Python API component: fx labels Apr 28, 2023

github-actions bot requested review from yinghai April 28, 2023 23:44

github-actions bot approved these changes Apr 28, 2023

View reviewed changes

narendasan added the Story: ATen Op Support label Apr 28, 2023

narendasan changed the title ~~refactor: Moving elementwise core to impl~~ refactor: Moving elementwise core to impl (FX Converter Refactor [3/N]) Apr 28, 2023

narendasan force-pushed the converter_reorg_proto branch from 9864d96 to 8822b66 Compare May 1, 2023 16:23

narendasan force-pushed the converter_reorg_elementwise branch from 6d399d7 to e442ce3 Compare May 1, 2023 16:26

github-actions bot approved these changes May 1, 2023

View reviewed changes

narendasan force-pushed the converter_reorg_elementwise branch from e442ce3 to b2ce9a6 Compare May 1, 2023 19:36

github-actions bot approved these changes May 1, 2023

View reviewed changes

narendasan force-pushed the converter_reorg_proto branch from 8822b66 to 1696cd2 Compare May 1, 2023 19:57

narendasan force-pushed the converter_reorg_elementwise branch from b2ce9a6 to 0d4e6d7 Compare May 1, 2023 20:45

github-actions bot approved these changes May 1, 2023

View reviewed changes

narendasan changed the title ~~refactor: Moving elementwise core to impl (FX Converter Refactor [3/N])~~ refactor: Moving elementwise core to impl (FX Converter Refactor [3/N]) <Target: converter_reorg_proto> May 12, 2023

narendasan requested a review from wushirong May 12, 2023 18:15

github-actions bot approved these changes May 12, 2023

View reviewed changes

gs-olive force-pushed the converter_reorg_proto branch from 1696cd2 to 12f545c Compare May 15, 2023 21:25

gs-olive force-pushed the converter_reorg_elementwise branch from 0d4e6d7 to 9611d67 Compare May 15, 2023 22:22

github-actions bot approved these changes May 15, 2023

View reviewed changes

apbose force-pushed the converter_reorg_elementwise branch from 9611d67 to 93846ed Compare May 30, 2023 20:46

github-actions bot added component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests labels May 30, 2023

narendasan force-pushed the converter_reorg_elementwise branch from 93846ed to 83986cd Compare May 30, 2023 20:54

github-actions bot added the component: partitioning label May 30, 2023

narendasan changed the base branch from converter_reorg_proto to main May 30, 2023 20:54

github-actions bot approved these changes May 30, 2023

View reviewed changes

gs-olive mentioned this pull request Jun 23, 2023

fix: Add automatic type promotion for FX elementwise ops #2055

Closed

apbose force-pushed the converter_reorg_elementwise branch from 546f975 to c8a9559 Compare June 26, 2023 16:11

github-actions bot approved these changes Jun 26, 2023

View reviewed changes

gs-olive mentioned this pull request Jun 30, 2023

fix: Move all aten PRs to Dynamo converter registry #2070

Merged

apbose force-pushed the converter_reorg_elementwise branch from c8a9559 to 8c0eb6f Compare July 6, 2023 18:09

github-actions bot approved these changes Jul 6, 2023

View reviewed changes

apbose force-pushed the converter_reorg_elementwise branch from 18e503b to 2caac76 Compare July 6, 2023 21:39

github-actions bot approved these changes Jul 6, 2023

View reviewed changes

narendasan and others added 3 commits July 6, 2023 14:42

refactor: Moving elementwise and unary core to impl

07b9266

Signed-off-by: Naren Dasan <naren@narendasan.com> new file: ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N])…

12e8aa9

… <Target: converter_reorg_elementwise> (#1905)

Changing torch_dtype_to_trt and torch_dtype_from_trt to unified_dtype…

2caac76

…_converter and adding convolution in acc_ops_converters.py and aten_ops_converters.py

narendasan closed this Jul 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Moving elementwise core to impl (FX Converter Refactor [3/N]) <Target: converter_reorg_proto> #1869

refactor: Moving elementwise core to impl (FX Converter Refactor [3/N]) <Target: converter_reorg_proto> #1869

narendasan commented Apr 28, 2023 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

narendasan commented May 20, 2023

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

narendasan commented Jul 17, 2023

refactor: Moving elementwise core to impl (FX Converter Refactor [3/N]) <Target: converter_reorg_proto> #1869

refactor: Moving elementwise core to impl (FX Converter Refactor [3/N]) <Target: converter_reorg_proto> #1869

Conversation

narendasan commented Apr 28, 2023 • edited Loading

Description

Type of change

Checklist:

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

narendasan commented May 20, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

narendasan commented Jul 17, 2023

narendasan commented Apr 28, 2023 •

edited

Loading