Skip to content

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

apbose
Copy link
Collaborator

@apbose apbose commented May 10, 2023

Fixes #1794

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- py/torch_tensorrt/fx/converters/aten_ops_converters.py	2023-05-10 05:57:24.442200 +0000
+++ py/torch_tensorrt/fx/converters/aten_ops_converters.py	2023-05-10 05:57:43.318756 +0000
@@ -325,15 +325,15 @@
    target: Target,
    args: Tuple[Argument, ...],
    kwargs: Dict[str, Argument],
    name: str,
) -> Union[TRTTensor, Sequence[TRTTensor]]:
-    
+
    return rsqrt(
-        network, 
-        target, 
-        SourceIR.ATEN, 
+        network,
+        target,
+        SourceIR.ATEN,
        name,
        args[0],
    )


--- py/torch_tensorrt/fx/test/converters/aten_op/test_rsqrt_aten.py	2023-05-10 05:57:24.450200 +0000
+++ py/torch_tensorrt/fx/test/converters/aten_op/test_rsqrt_aten.py	2023-05-10 05:57:45.176604 +0000
@@ -24,6 +24,6 @@
            expected_ops={torch.ops.aten.rsqrt.default},
        )


if __name__ == "__main__":
-    run_tests()
\ No newline at end of file
+    run_tests()

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@apbose apbose requested review from narendasan, frank-wei and wushirong and removed request for yinghai May 12, 2023 16:59
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@narendasan narendasan changed the title Moving elementwise core to impl - rsqrt (FX Converter Refactor [4/N]) Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) May 12, 2023
@apbose apbose changed the title Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> May 15, 2023
@gs-olive gs-olive force-pushed the converter_reorg_elementwise branch from 0d4e6d7 to 9611d67 Compare May 15, 2023 22:22
@gs-olive gs-olive force-pushed the converter_reorg_elementwise_rsqrt branch from 4466ada to 526b2e2 Compare May 15, 2023 22:27
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@apbose apbose force-pushed the converter_reorg_elementwise branch from 9611d67 to 93846ed Compare May 30, 2023 20:46
@narendasan narendasan force-pushed the converter_reorg_elementwise branch from 93846ed to 83986cd Compare May 30, 2023 20:54
gs-olive added a commit that referenced this pull request Jul 7, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 7, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix
gs-olive added a commit that referenced this pull request Jul 7, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 10, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix
gs-olive added a commit that referenced this pull request Jul 10, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 12, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix
gs-olive added a commit that referenced this pull request Jul 12, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 12, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix
gs-olive added a commit that referenced this pull request Jul 12, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 14, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix
gs-olive added a commit that referenced this pull request Jul 14, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 14, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix
gs-olive added a commit that referenced this pull request Jul 14, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 19, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix
gs-olive added a commit that referenced this pull request Jul 19, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 19, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix
gs-olive added a commit that referenced this pull request Jul 19, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 19, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix
gs-olive added a commit that referenced this pull request Jul 19, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 20, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix
gs-olive added a commit that referenced this pull request Jul 20, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 21, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix
gs-olive added a commit that referenced this pull request Jul 21, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 21, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix
gs-olive added a commit that referenced this pull request Jul 21, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 21, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix
gs-olive added a commit that referenced this pull request Jul 21, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 24, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix
gs-olive added a commit that referenced this pull request Jul 24, 2023
Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.
gs-olive pushed a commit that referenced this pull request Jul 25, 2023
refactor: Moving elementwise and unary core to impl

Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py

Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)

Converter reorg fmod

Converter reorg and rsub

Rsub error fixes and linting error fixed

Rsub test case to include different inputs

Converter reorg batch norm

batch norm error fix and linting issue error fix

layer_norm converter

Layer norm linting correction

ops file correction

fixing lint

Acc_ops layer_norm correction

Converter reorg and softmax operation

softmax linting error fix

Converter reorg and gelu

Linting error

Converter reorg and squeeze operator

Correcting squeeze operator implementation, linting error and acc squeeze test

Adding the condition to convert dim to int and removing the comment

Converter reorg and select operation

select operation correction and linting changes

converter reorg and slice

converter reorg slice op

Correcting linting error and slice changes

Correcting the slice operation

converter reorg and matmul

Matmul issue fixes and lint error check

moving matmul to individual file

Converter reorg and where operator

adding where aten op

aten::where correction and linting error changes

aten::unsqueeze impl refactor

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Moved clamp to impl

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fixed method name

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

fix: Add automatic type promotion for FX ops

- Implement functionality to cast tensors to alternative types
- Add functionality to elementwise ops to promote types and perform
necessary casts
- Address issues in FX ops where mixed-precision computations can
cause errors
- Add test cases to validate fix

Revert all changes to py/torch_tensorrt/fx

Revert "fix: Add automatic type promotion for FX ops"

This reverts commit f1f3716.

Revert "Moved clamp to impl"

This reverts commit df401dd.

Revert "aten::unsqueeze impl refactor"

This reverts commit b424735.

Revert "Converter reorg and where operator"

This reverts commit b4da15e.

Revert "converter reorg and matmul"

This reverts commit 7551eee.

Revert "converter reorg and slice"

This reverts commit 9bbdc9e.

Revert "Converter reorg and select operation"

This reverts commit fb70253.

Revert "Converter reorg and squeeze operator"

This reverts commit 294545c.

Revert "Converter reorg and gelu"

This reverts commit 37d1168.

Revert "Converter reorg and softmax operation"

This reverts commit 1ba6d13.

Revert "layer_norm converter"

This reverts commit e0b34b1.

Revert "Converter reorg batch norm"

This reverts commit 59354e5.

Revert "Converter reorg and rsub"

This reverts commit db15d27.

Revert "Converter reorg fmod"

This reverts commit ce3fa67.

Revert "Moving elementwise core to impl - rsqrt (FX Converter Refactor [9/N]) <Target: converter_reorg_elementwise> (#1905)"

This reverts commit 7158ca5.

Revert "refactor: Moving elementwise and unary core to impl"

This reverts commit 45e43ca.

fix: Replay all FX changes in Dynamo

- Add multiple fixes to make FX changes appear in Dynamo directory,
using Dynamo registry
- All converters with open PRs are linked and shown
- Update references, imports, code, merges, rebases accordingly
- Add new test cases to Dynamo for converters

Temporarily removing rsub pending fix

Fixing clamp to not use Torch

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Fixing select to not use torch

fix: Reorganize folders in latest implementation

- Update test references and imports accordingly

Embedding operator in dynamo

reciprocal lowering pass

fix: Fix for Dynamic Shape Tests + Input class

feat: Add permute operation implementation

chore: Move converter registry, update imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants