fix: Add automatic type promotion for FX elementwise ops #2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apbose
force-pushed
the
converter_reorg_elementwise
branch
from
546f975 to
c8a9559
Compare
gs-olive
force-pushed
the
fx_type_promotion
branch
from
9cc2d9d to
24f4781
Compare
gs-olive
force-pushed
the
fx_type_promotion
branch
from
24f4781 to
a5b3fae
Compare
apbose
force-pushed
the
converter_reorg_elementwise
branch
2 times, most recently
from
18e503b to
2caac76
Compare
gs-olive
force-pushed
the
fx_type_promotion
branch
from
a5b3fae to
d15962e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- py/torch_tensorrt/fx/converters/impl/elementwise/base.py 2023-07-06 22:40:20.742725 +0000
+++ py/torch_tensorrt/fx/converters/impl/elementwise/base.py 2023-07-06 22:40:40.009356 +0000
@@ -127,11 +127,12 @@
lhs_val = get_trt_tensor(network, lhs_val, f"{name}_lhs", lhs_dtype)
rhs_val = get_trt_tensor(network, rhs_val, f"{name}_rhs", rhs_dtype)
promoted_type = torch.promote_types(
- unified_dtype_converter(lhs_val.dtype, Frameworks.TORCH), unified_dtype_converter(rhs_val.dtype, Frameworks.TORCH)
+ unified_dtype_converter(lhs_val.dtype, Frameworks.TORCH),
+ unified_dtype_converter(rhs_val.dtype, Frameworks.TORCH),
)
trt_promoted_type = unified_dtype_converter(promoted_type, Frameworks.TRT)
if trt_promoted_type != lhs_val.dtype:
lhs_val = cast_trt_tensor(network, lhs_val, trt_promoted_type, name)
- Implement functionality to cast tensors to alternative types - Add functionality to elementwise ops to promote types and perform necessary casts - Address issues in FX ops where mixed-precision computations can cause errors - Add test cases to validate fix
gs-olive
force-pushed
the
fx_type_promotion
branch
from
d15962e to
a720f5d
Compare
|
Closed as changes were merged into Dynamo #2070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1995
Type of change
Checklist: