Skip to content

Moving permute core to impl - permute(FX Converter Refactor [22/N]) <Target: converter_reorg_elementwise> #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

borisfom
Copy link
Collaborator

@borisfom borisfom commented Jun 8, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

narendasan and others added 3 commits May 30, 2023 13:53
Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
narendasan and others added 2 commits June 26, 2023 09:14
Signed-off-by: Naren Dasan <naren@narendasan.com>

	new file:   ../converters/impl/unary/base.py
@borisfom borisfom changed the title Moving permute core to impl - clamp(FX Converter Refactor [22/N]) <Target: converter_reorg_elementwise> Moving permute core to impl - permute(FX Converter Refactor [22/N]) <Target: converter_reorg_elementwise> Jun 29, 2023
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
@narendasan narendasan requested a review from gs-olive August 1, 2023 21:47
@gs-olive
Copy link
Collaborator

gs-olive commented Aug 2, 2023

torch.ops.aten.permute.default was included in #2070

@gs-olive gs-olive closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants