Merge upstream@0.24.0 #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed for e2e testing Reviewed By: mkonicek, frantic Differential Revision: D3087524 fb-gh-sync-id: 048e23b55916a6be17fa9fabb6e41b0b2f3f7a16 shipit-source-id: 048e23b55916a6be17fa9fabb6e41b0b2f3f7a16
Summary: This property is only used by the native code as an optimization to not send events that no one is listening to. We don't need to expose it externally on the js api. Set sendMomentumEvent to be a native only property. Reviewed By: bestander Differential Revision: D3092650 fb-gh-sync-id: 95f5f0ae4cd04a7d1cbc9cf17c93647d3c644878 shipit-source-id: 95f5f0ae4cd04a7d1cbc9cf17c93647d3c644878
Summary:This is the first from the series of PRs I'm going to be sending shorty that would let Animated.js animations to run off the JS thread (for Android only). This PR introduce a new native module that will be used for offloading animations - NativeAnimatedModule. It has a simple API that allows for animated nodes management via methods like: create/drop animated node, connect/disconnect nodes, start animation of a value node, attach/detach animated from a native view. Similarly to how we handle UIManager view hierarchy updates we create a queue of animated graph operations that are then executed on the UI thread. This isolates us from problems that may be caused by concurrent updates of animated graph while UI thread is "executing" the animation. The most important class NativeAnimatedNodesManager.java implements a management interface for animated nodes graph as well as implements a graph traversal algorithm that is run for each animation frame. For each animation frame we visit animated nodes th Closes facebook/react-native#6466 Differential Revision: D3092739 Pulled By: astreet fb-gh-sync-id: 665b49900b7367c91a93b9d8864f78fb90bb36ba shipit-source-id: 665b49900b7367c91a93b9d8864f78fb90bb36ba
Reviewed By: dmmiller Differential Revision: D3087133 fb-gh-sync-id: cb3b073dd77d40fb051a9bc17b6c24b49a325371 shipit-source-id: cb3b073dd77d40fb051a9bc17b6c24b49a325371
Summary: Closes facebook/react-native#6621 Differential Revision: D3092794 fb-gh-sync-id: f5e75377f00d8215e0e026dfe1f682c832f1e7e6 shipit-source-id: f5e75377f00d8215e0e026dfe1f682c832f1e7e6
Reviewed By: martinbigio Differential Revision: D3011797 fb-gh-sync-id: 9f7ddc7b3c0c0e2a78db829343d9fa93a46b4ad6 shipit-source-id: 9f7ddc7b3c0c0e2a78db829343d9fa93a46b4ad6
Summary:Fixes proguard in RN 0.22.+. Closes #6624 Closes facebook/react-native#6626 Differential Revision: D3092892 fb-gh-sync-id: 3aaf97c6f1c7b5d575cb912196b43955d9ef10fb shipit-source-id: 3aaf97c6f1c7b5d575cb912196b43955d9ef10fb
Summary: Closes facebook/react-native#6623 Differential Revision: D3092891 fb-gh-sync-id: 9745bf191096c874cabb51c87579c57cb066c205 shipit-source-id: 9745bf191096c874cabb51c87579c57cb066c205
Summary:npm-publish.js is not cohesive enough: besides building and publishing it also modifies some files. It is better to have a separate script that will bump versions, make a commit and tag it. scripts/bump-oss-version.js does exactly that. This simplifies release process and allows manual release to npm if CI is not available. Closes facebook/react-native#6625 Differential Revision: D3092849 fb-gh-sync-id: 92cf38bd3df31c8c9c433fc5f9e15c129855fe0e shipit-source-id: 92cf38bd3df31c8c9c433fc5f9e15c129855fe0e
Summary:FBPortForwarding is incomplete and flaky implementation of `adb reverse` functionality for iOS. We haven't worked on it internally for a while now, but I think it might be a very usefull tool for the community. Some external contributors (hello philikon!) expressed interest in maintaining it. This diff moves it over to OSS RN `Libraries` folder. Reviewed By: vjeux Differential Revision: D3056293 fb-gh-sync-id: 9ced61fa8480a923771bba26fe09337c344ab3b3 shipit-source-id: 9ced61fa8480a923771bba26fe09337c344ab3b3
Summary:Source maps are broken on Genymotion right now as they aren't being loaded from the correct URL. refer - facebook/react-native#5338 (comment) **Test plan** Build and install UIExplorer from master branch in genymotion and enable hot reload. When you change a file and save it, you'll see a Yellow box due to source map fetching failed, as per the referenced comment. Doing the same for this branch doesn't produce any yellow boxes. Closes facebook/react-native#6594 Differential Revision: D3088218 Pulled By: martinbigio fb-gh-sync-id: 0d1c19cc263de5c6c62061c399eef33fa4ac4a7b shipit-source-id: 0d1c19cc263de5c6c62061c399eef33fa4ac4a7b
Summary:I suppose over time we should simplify the script. But for now this will do. Logic: 1. don't copy "blog" folder to /releases/XX when doing a docs release 2. don't copy "blog" folder to / when doing stable docs release 3. copy "blog" folder to / only when doing building docs for master branch CC vjeux Closes facebook/react-native#6634 Differential Revision: D3094267 Pulled By: vjeux fb-gh-sync-id: 1f972703ed371c114e34d9f524092ea1d2fd985b shipit-source-id: 1f972703ed371c114e34d9f524092ea1d2fd985b
Summary:Ported the infrastructure from jest.  Closes facebook/react-native#6629 Differential Revision: D3094423 Pulled By: vjeux fb-gh-sync-id: a01aec6a55d28484c45bb241d037ca6717bc5e81 shipit-source-id: a01aec6a55d28484c45bb241d037ca6717bc5e81
Summary:Currently there?s an inconsistency between the animations used in `NavigationAnimatedView` (`spring`) and those in `NavigationCardStack` (`timing`), which is noticeable when switching between the two implementations. By removing the `_applyAnimation` method, the `NavigationAnimatedView` will simply use its [default `applyAnimation`](https://github.com/facebook/react-native/blob/6c22a2174e733d536a12f47a2da4f84329ac3023/Libraries/NavigationExperimental/NavigationAnimatedView.js#L56-L67), making the animation styles the same. **Before** (with `Animated.timing`) Video: http://quick.as/Yexku8DdJ **After** (with the default `NavigationAnimatedView` animations) Video: http://quick.as/qrqbsnj8n Closes facebook/react-native#6636 Differential Revision: D3094638 Pulled By: ericvicenti fb-gh-sync-id: 6e1c7c54b4ef102c4003719381d334d2c6f7a531 shipit-source-id: 6e1c7c54b4ef102c4003719381d334d2c6f7a531
Summary:This avoids flattening styles in most common cases. It diffs against the nested arrays. The special case is when a property gets removed, it creates an object that stores the removed keys which then gets resolved using a second pass through the nested array. You can conceptually think of this algorithm as: 1) Diff and store changes as you go 2) If something was removed, flatten as necessary I also merged in another commit that renames the StyleSheetRegistry to ReactNativePropRegistry. There is nothing in here that makes it specific to styles anymore. That's just a decoupled view attribute configuration option. This registry can be used for any set of nested props, if we even want to keep this feature at all. Reviewed By: vjeux Differential Revision: D2492885 fb-gh-sync-id: c976ac28b7e63545132c36da0ee0c1c562e7c9e5 shipit-source-id: c976ac28b7e63545132c36da0ee0c1c562e7c9e5
Summary:- All the public sub component renderers should implement the interface NavigationSceneRenderer, which will help to reuse renderer or replace renders for different composition. - Perf improvement. <NavigationHeader /> is rendering way more sub component than necessary, we shall fix that. - No UI or behavior change. Reviewed By: ericvicenti Differential Revision: D3091442 fb-gh-sync-id: fba5f7ce74597fa6036b5b216c02b06052801983 shipit-source-id: fba5f7ce74597fa6036b5b216c02b06052801983
Reviewed By: AaaChiuuu Differential Revision: D3096157 fb-gh-sync-id: 6bcca134e5e7a426719816047ffc98a5178e9596 shipit-source-id: 6bcca134e5e7a426719816047ffc98a5178e9596
Reviewed By: astreet Differential Revision: D3091688 fb-gh-sync-id: 4f91d5126a16b56904fa4af7acdc32b9bb873c6d shipit-source-id: 4f91d5126a16b56904fa4af7acdc32b9bb873c6d
Summary:Fix bad wording in the docs change I did in #6534 cc mkonicek Closes facebook/react-native#6598 Differential Revision: D3085957 Pulled By: vjeux fb-gh-sync-id: 2b45ac72acf089be6cf8e815aac430a2ce9d08ed shipit-source-id: 2b45ac72acf089be6cf8e815aac430a2ce9d08ed
Reviewed By: sam-swarr Differential Revision: D3089888 fb-gh-sync-id: 61779538cd11cc0b62e851f7dd10a1d2ed4f07a3 fbshipit-source-id: 61779538cd11cc0b62e851f7dd10a1d2ed4f07a3
Summary: The HMR codepath is currently broken because of a recent change that tries to compute the absolute entryFile path (needed for RAM Bundling). HMR Bundler's bundles are special as they contains a single file (the file that was transformed). However, for performance reasons we recycle an existing resolution response which contains the polyfills and the module system modules. Reviewed By: sam-swarr Differential Revision: D3098069 fb-gh-sync-id: 23d61aa304cd6f59d4df4840965f5eedda05dc31 fbshipit-source-id: 23d61aa304cd6f59d4df4840965f5eedda05dc31
Summary: Closes facebook/react-native#6657 Differential Revision: D3098193 Pulled By: martinbigio fb-gh-sync-id: 535cba9767494b886c03a1d67e71f4ebb3eb48f7 fbshipit-source-id: 535cba9767494b886c03a1d67e71f4ebb3eb48f7
Summary:This puts the images inside of the blog folder in the output so we can safely copy them over. And moves the images in /blog/img/ in the source control so it's easier to discover (instead of having to search many levels deep). Should make the website work! Closes facebook/react-native#6659 Differential Revision: D3098308 Pulled By: vjeux fb-gh-sync-id: 99477e27843dd6c88aa854028944f2f0b672db1f fbshipit-source-id: 99477e27843dd6c88aa854028944f2f0b672db1f
Summary:Indicates the purpose and an alternative use for the method too. Closes facebook/react-native#6662 Differential Revision: D3099823 Pulled By: vjeux fb-gh-sync-id: 44633161a3df9b11d44afaed72fe6127f0b6bf7b fbshipit-source-id: 44633161a3df9b11d44afaed72fe6127f0b6bf7b
Summary: Minor improvements to the <Switch> docblock, including adding some keywords to make it easier to find. Also, I updated documentation for the deprecated platform-specific versions of the component. Reviewed By: jingc Differential Revision: D3098626 fb-gh-sync-id: 86d0f1a45eb8ac1bd9e58ac4ba9c73a4a3dfa846 fbshipit-source-id: 86d0f1a45eb8ac1bd9e58ac4ba9c73a4a3dfa846
Summary: Closes facebook/react-native#5401 Differential Revision: D3102058 fb-gh-sync-id: 953a69a2a50b7177a4b0ee01972f5d32d5476f5c fbshipit-source-id: 953a69a2a50b7177a4b0ee01972f5d32d5476f5c
Summary:Gains minor perf improvement in the for loop by caching the array length Closes facebook/react-native#6671 Differential Revision: D3102064 fb-gh-sync-id: 2303d83f3672a2768c60d0e5dae999b1dda0d6bd fbshipit-source-id: 2303d83f3672a2768c60d0e5dae999b1dda0d6bd
Summary:The doc of props "navigationBar" in Navigator is not detailed enough. I make an improvement to it. Closes facebook/react-native#6615 Differential Revision: D3102065 fb-gh-sync-id: da96e3c422e053d0a8203bbd160ea10ed590878a fbshipit-source-id: da96e3c422e053d0a8203bbd160ea10ed590878a
Summary:The `onRequestClose` prop can be used to handle dismissing the modal by back button. It's pretty easy to miss the `onRequestClose` prop on Android. So making it a required prop makes sure that it generates a warning when not supplied. Context #6612 Closes facebook/react-native#6667 Differential Revision: D3102054 Pulled By: javache fb-gh-sync-id: 878240606285d231b5592a438918e441765bfe5f fbshipit-source-id: 878240606285d231b5592a438918e441765bfe5f
Summary:We don't support the latest NDK (`r11b`) and Google no longer provides links for the old version on the official page. So add them to the docs for now. cc kmagiera astreet Closes facebook/react-native#6668 Differential Revision: D3102125 fb-gh-sync-id: 0a54e1c7f2ff883ca516c30cda279c828bd5a6e2 fbshipit-source-id: 0a54e1c7f2ff883ca516c30cda279c828bd5a6e2
Summary: Closes facebook/react-native#6977 Differential Revision: D3178986 fb-gh-sync-id: 642b96fefcc506d1f8ada588ed79e5de48829338 fbshipit-source-id: 642b96fefcc506d1f8ada588ed79e5de48829338
Summary:Fixes an issue where if you implement `renderScrollComponent` and have a `ref` callback on the returned element, the ref used to be clobbered by the ref that ListView adds to the element. This is accomplished by converting the ref from a legacy string-based ref to a callback-based ref, and then using `cloneReferencedElement`, which is a simple utility to compose callback refs. Closes facebook/react-native#6441 Differential Revision: D3064250 Pulled By: mkonicek fb-gh-sync-id: 2d55d04e2144a1cc08900a57a1fc0dab07c87eea fbshipit-source-id: 2d55d04e2144a1cc08900a57a1fc0dab07c87eea
Summary:fixes Circle Closes facebook/react-native#6978 Differential Revision: D3179133 fb-gh-sync-id: 6558168735b4097a68bf7423a7c249a45cc2684a fbshipit-source-id: 6558168735b4097a68bf7423a7c249a45cc2684a
Reviewed By: javache Differential Revision: D3177081 fb-gh-sync-id: 987167033329413cd0a4b296ca849758ec87368c fbshipit-source-id: 987167033329413cd0a4b296ca849758ec87368c
Summary:Set `Touchable.TOUCH_TARGET_DEBUG` to see colored borders/text to all touchables. Different touchable types are color-coded differently. If there is `hitSlop`, it will be rendered with an extra view with a dashed border of the same color (not visible on Android because `overflow: 'hidden'`). `Text` with `onPress` directly set is just colored. Added some extra checks to `TouchableWithoutFeedback` since it could silently break if the child is not a native component. Also added better error output for `ensureComponentIsNative` so it's easier to track down issues. I really wish there was a cleaner way to get the component and owner names consistently, it would help make good debug messages way easier to write. Reviewed By: ericvicenti Differential Revision: D3149865 fb-gh-sync-id: 602fc3474ae7636e32af529eb7ac52ac5b858030 fbshipit-source-id: 602fc3474ae7636e32af529eb7ac52ac5b858030
Summary: Closes facebook/react-native#6980 Differential Revision: D3181069 fb-gh-sync-id: ed39452c071c83e5fede352d61b3a293180f5b52 fbshipit-source-id: ed39452c071c83e5fede352d61b3a293180f5b52
Reviewed By: bestander Differential Revision: D3182004 fb-gh-sync-id: 7346e3fd85eeed8ba103ccc1fd60c86c8a656712 fbshipit-source-id: 7346e3fd85eeed8ba103ccc1fd60c86c8a656712
Reviewed By: mroch Differential Revision: D3179969 fb-gh-sync-id: e0513a17d565ff1ae5c6e58c49ce82b6b0d5db86 fbshipit-source-id: e0513a17d565ff1ae5c6e58c49ce82b6b0d5db86
Summary: Closes facebook/react-native#6983 Differential Revision: D3182175 fb-gh-sync-id: 966a5ed11bb70bb48d74b1b755ff00099c60d78b fbshipit-source-id: 966a5ed11bb70bb48d74b1b755ff00099c60d78b
Summary:Fix for #6963 Closes facebook/react-native#6982 Differential Revision: D3180164 Pulled By: ericvicenti fb-gh-sync-id: 234d3027097ae032ba0e24470adb3a5ebf07e351 fbshipit-source-id: 234d3027097ae032ba0e24470adb3a5ebf07e351
Reviewed By: bestander Differential Revision: D3182609 fb-gh-sync-id: 23392ecbdc589aaa8b76465f64f28790e7e61903 fbshipit-source-id: 23392ecbdc589aaa8b76465f64f28790e7e61903
Summary:Portal keeps its opened modals as a state member. so if multiple consecutive `_showModal` or `_closeModal` are called, it will only read the initial state and merge the end result, which causes some close or open calls to be overwritten due to race condition. This diff fixes such issue. Reviewed By: dmmiller Differential Revision: D3160561 fb-gh-sync-id: 6d936c795660b119e2d3fe8b3ab807307eca92c5 fbshipit-source-id: 6d936c795660b119e2d3fe8b3ab807307eca92c5
Summary:This change will change the returnKeyType to be "return" instead of being "done" since this example is trying to provide a example of a auto growing text input multiple use-case. It makes that the return key says just return in order to expand the input instead of done which does not really show the use of multiline. Closes facebook/react-native#6991 Differential Revision: D3184157 fb-gh-sync-id: dd0c21433009600d3cc585b941b089cab4895e7a fbshipit-source-id: dd0c21433009600d3cc585b941b089cab4895e7a
Summary:SSIA. Closes facebook/react-native#6990 Differential Revision: D3184330 fb-gh-sync-id: 3fe799f252c868dc8280f38b807d4e2fd5a33241 fbshipit-source-id: 3fe799f252c868dc8280f38b807d4e2fd5a33241
Summary:`externalCacheDir == null && externalCacheDir == null` is obviously a typo in existing code. Closes facebook/react-native#6429 Differential Revision: D3184362 fb-gh-sync-id: 1cd966ed96414348c4319d44679d2c912df6cc93 fbshipit-source-id: 1cd966ed96414348c4319d44679d2c912df6cc93
Summary:Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: (You can skip this if you're fixing a typo or adding an app to the Showcase.) Explain the **motivation** for making this change. What existing problem does the pull request solve? Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). Closes facebook/react-native#6688 Differential Revision: D3184356 fb-gh-sync-id: d508150202373ccb6c33f6af16ef545222463f98 fbshipit-source-id: d508150202373ccb6c33f6af16ef545222463f98
…st for Android and iOS Summary:Currently React-Native does not have `ontimeout` and `onerror` handlers for [XMLHttpRequest](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest). This is an extension to [No timeout on XMLHttpRequest](facebook/react-native#4648). With addition to two handlers, both Android and iOS can now handle `ontimeout` if request times out and `onerror` when there is general network error. **Test plan** Code has been tested on both Android and iOS with [Charles](https://www.charlesproxy.com/) by setting a breakpoint on the request which fires `ontimeout` when the request waits beyond `timeout` time and `onerror` when there is network error. **Usage** JavaScript - ``` var request = new XMLHttpRequest(); function onLoad() { console.log(request.status); }; function onTimeout() { console.log('Timeout'); }; function onError() { console.log('General network error'); }; request.onload = onLoad; request.ontimeout = onTimeout; request.onerr Closes facebook/react-native#6841 Differential Revision: D3178859 Pulled By: lexs fb-gh-sync-id: 30674570653e92ab5f7e74bd925dd5640fc862b6 fbshipit-source-id: 30674570653e92ab5f7e74bd925dd5640fc862b6
…vior
Fix some issues with TextInput:
1. It now draws background.
2. Add focusRingType property: <TextInput focusRingType={'none'} />
3. Workaround with a placeholder (respect the color, size on the focus).
4. SelectionColor <TextInput selectionColor={'blue'} />
The issue with null backgroundColor causes weird behavior Currently disabled padding cell due to other bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the way to easier merges.