Imporve docs for the prop "navigationBar" in Navigator #6615
Conversation
|
By analyzing the blame information on this pull request, we identified @ericvicenti, @hedgerwang and @astreet to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
| * Optionally provide a component as navigation bar that persists across scene | ||
| * transitions. The component will receive two props: `navigator` and `navState`. | ||
| * It will be rerendered when the routes change. | ||
| */ |
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
@starkwang updated the pull request. |
satya164
changed the title
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
Summary:The doc of props "navigationBar" in Navigator is not detailed enough. I make an improvement to it. Closes facebook#6615 Differential Revision: D3102065 fb-gh-sync-id: da96e3c422e053d0a8203bbd160ea10ed590878a fbshipit-source-id: da96e3c422e053d0a8203bbd160ea10ed590878a
The doc of props "navigationBar" in Navigator is not detailed enough. I make an improvement to it.