Skip to content

Introduce blog #6629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Introduce blog #6629

wants to merge 1 commit into from

Conversation

vjeux
Copy link
Contributor

@vjeux vjeux commented Mar 24, 2016

Ported the infrastructure from jest.

screen shot 2016-03-24 at 9 47 50 am

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 24, 2016
@janicduplessis
Copy link
Contributor

Nooo it will break the mobile layout :((

On a more serious note, should we move Newsletter somewhere else since the top bar is getting a bit crowded. It seems like the less important tab and is an external link. It is also pretty similar to the blog.

@vjeux
Copy link
Contributor Author

vjeux commented Mar 24, 2016

Agreed it is crowded. Idea: we can move the newsletter as part of showcase. I would see

[featured]
[newsletter embed]
[rest of them]

@janicduplessis
Copy link
Contributor

It would fit nicely but it doesn't feel related to showcase. Maybe a link in the blog sidebar before/after recent posts? There is also the footer but it isn't visible at all on the home page.

@vjeux
Copy link
Contributor Author

vjeux commented Mar 24, 2016

screen shot 2016-03-24 at 12 30 36 pm

@vjeux
Introduce blog
f630707 
Ported the infrastructure from jest.
@facebook-github-bot
Copy link
Contributor

@vjeux updated the pull request.

@brentvatne
Copy link
Collaborator

:shipit:

@vjeux
Copy link
Contributor Author

vjeux commented Mar 24, 2016

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review.

janicduplessis
janicduplessis reviewed Mar 24, 2016
View reviewed changes
website/core/BlogPost.js
<h1>{post.title}</h1>
<p className="meta">
{month} {day}, {year} by{' '}
<a href={post.authorURL} target="_blank">{post.author}</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will act weird if there is no authorURL (like in the current blog post). Should probably either make it only text if there is no URL or make sure to always include an authorURL for each blog post.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed!

@ghost ghost closed this in b80698d Mar 24, 2016
bestander
bestander reviewed Mar 25, 2016
View reviewed changes
website/core/HeaderLinks.js
{section: 'support', href: 'support.html', text: 'Support'},
{section: 'newsletter', href: 'http://reactnative.cc', text: 'Newsletter'},
{section: 'showcase', href: 'showcase.html', text: 'Showcase'},
{section: 'blog', href: 'blog/', text: 'Blog'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vjeux this should be href: '/react-native/blog'.
Otherwise BASE setting will prepend /react-native/release/XX to the link and it won't work for people who navigate other versions but stable.

zebulgar pushed a commit to nightingale/react-native that referenced this pull request Jun 18, 2016
@vjeux @zebulgar
Introduce blog
e94b397 
Summary:Ported the infrastructure from jest.

![screen shot 2016-03-24 at 9 47 50 am](https://cloud.githubusercontent.com/assets/197597/14024237/85db1132-f1a5-11e5-84be-f525e302c6ca.png)
Closes facebook#6629

Differential Revision: D3094423

Pulled By: vjeux

fb-gh-sync-id: a01aec6a55d28484c45bb241d037ca6717bc5e81
shipit-source-id: a01aec6a55d28484c45bb241d037ca6717bc5e81
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vjeux @janicduplessis @facebook-github-bot @brentvatne @bestander