Fix ImageEditingManager when no external cache #6429
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@facebook-github-bot shipit |
|
@gre updated the pull request. |
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary:`externalCacheDir == null && externalCacheDir == null` is obviously a typo in existing code. Closes facebook#6429 Differential Revision: D3184362 fb-gh-sync-id: 1cd966ed96414348c4319d44679d2c912df6cc93 fbshipit-source-id: 1cd966ed96414348c4319d44679d2c912df6cc93
Trancever
pushed a commit
to Trancever/react-native-image-editor
that referenced
this pull request
Feb 12, 2019
Summary:`externalCacheDir == null && externalCacheDir == null` is obviously a typo in existing code. Closes facebook/react-native#6429 Differential Revision: D3184362 fb-gh-sync-id: 1cd966ed96414348c4319d44679d2c912df6cc93 fbshipit-source-id: 1cd966ed96414348c4319d44679d2c912df6cc93
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
externalCacheDir == null && externalCacheDir == nullis obviously a typo in existing code.