Fix ImageEditingManager when no external cache

gre · Facebook Github Bot 7 · commit 5d0751a6d62a · 2016-04-15T04:51:25.000-07:00
Summary:`externalCacheDir == null && externalCacheDir == null` is obviously a typo in existing code. Closes facebook/react-native#6429 Differential Revision: D3184362 fb-gh-sync-id: 1cd966ed96414348c4319d44679d2c912df6cc93 fbshipit-source-id: 1cd966ed96414348c4319d44679d2c912df6cc93
diff --git a/ImageEditingManager.java b/ImageEditingManager.java
@@ -485,7 +485,7 @@ private static File createTempFile(Context context, @Nullable String mimeType)
     File externalCacheDir = context.getExternalCacheDir();
     File internalCacheDir = context.getCacheDir();
     File cacheDir;
-    if (externalCacheDir == null && externalCacheDir == null) {
+    if (externalCacheDir == null && internalCacheDir == null) {
       throw new IOException("No cache directory available");
     }
     if (externalCacheDir == null) {

Original file line number	Diff line number	Diff line change
`@@ -485,7 +485,7 @@ private static File createTempFile(Context context, @Nullable String mimeType)`
`485`	`485`	`File externalCacheDir = context.getExternalCacheDir();`
`486`	`486`	`File internalCacheDir = context.getCacheDir();`
`487`	`487`	`File cacheDir;`
`488`		`- if (externalCacheDir == null && externalCacheDir == null) {`
	`488`	`+ if (externalCacheDir == null && internalCacheDir == null) {`
`489`	`489`	`throw new IOException("No cache directory available");`
`490`	`490`	`}`
`491`	`491`	`if (externalCacheDir == null) {`