Version release script #6625
Closed
Version release script #6625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @bestander and @mkonicek to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@bestander updated the pull request. |
bestander
force-pushed
the
version-release-script
branch
from
e23d402 to
697300e
Compare
|
@bestander updated the pull request. |
|
|
||
| artifacts { | ||
| archives androidSourcesJar | ||
| // TODO Make Javadoc generation work with Java 1.8, currently only works with 1.7 |
|
@facebook-github-bot shipit |
|
@bestander updated the pull request. |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
9 tasks
ghost
closed this
in
mkonicek
pushed a commit
that referenced
this pull request
Mar 31, 2016
Summary:npm-publish.js is not cohesive enough: besides building and publishing it also modifies some files. It is better to have a separate script that will bump versions, make a commit and tag it. scripts/bump-oss-version.js does exactly that. This simplifies release process and allows manual release to npm if CI is not available. Closes #6625 Differential Revision: D3092849 fb-gh-sync-id: 92cf38bd3df31c8c9c433fc5f9e15c129855fe0e shipit-source-id: 92cf38bd3df31c8c9c433fc5f9e15c129855fe0e
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary:npm-publish.js is not cohesive enough: besides building and publishing it also modifies some files. It is better to have a separate script that will bump versions, make a commit and tag it. scripts/bump-oss-version.js does exactly that. This simplifies release process and allows manual release to npm if CI is not available. Closes facebook#6625 Differential Revision: D3092849 fb-gh-sync-id: 92cf38bd3df31c8c9c433fc5f9e15c129855fe0e shipit-source-id: 92cf38bd3df31c8c9c433fc5f9e15c129855fe0e
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm-publish.js is not cohesive enough: besides building and publishing it also modifies some files.
It is better to have a separate script that will bump versions, make a commit and tag it.
scripts/bump-oss-version.js does exactly that.
This simplifies release process and allows manual release to npm if CI is not available.