Publish new functional color system #224
Conversation
🦋 Changeset detectedLatest commit: e3cd86e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primitives/FiLh2apndXtKZVug9A5hi7Yk9w47 |
colebemis
requested review from
jonrohan and
simurai
and removed request for
a team
|
@simurai Yeah, let's hold off until we remove the feature flag from github.com. In the meantime, we'll need to keep this branch up-to-date if we make bug fixes. |
| - name: Compute variable count | ||
| run: npx ts-node .github/v2-var-count.ts | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
The variables in colors/ and colors_v2/ are the same now so this action won't give us useful information anymore.
| @@ -1,86 +0,0 @@ | |||
| import {merge} from '../../src/utils' | |||
There was a problem hiding this comment.
Does this deletion count as major? Or was the direct data/colors/dark_dimmed never used by external users?
There was a problem hiding this comment.
These source files are never referenced directly so it has no impact on consumers.
| "introShelf.gradientRight": "success.subtle", | ||
| "introShelf.gradientIn": "canvas.default", | ||
| "introShelf.gradientOut": null | ||
| } |
There was a problem hiding this comment.
Just a side thought, it would be awesome to automate this script and have actions check it in on prs. So nobody will have to remember to re-run the script.
There was a problem hiding this comment.
Yeah, I thought about that too. But I'm curious if that's something we always want to automate.
There was a problem hiding this comment.
Let's see how the manually keep the file up-to-date goes after the v2 migration, then we can re-evaluate.
Summary
For the past few months, we've been testing new color variables (stored in the
colors_v2directory) on github.com. We're now ready to add the new color variables to thecolorsdirectory and deprecate old color variables.This PR does the following:
Note: We should not release this change until we've updated our color system docs (#225)