-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document new functional color system #225
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primitives/9KBVT1DzdWSTYjqhXvt6fQdZfr43 |
|
docs/src/components/swatch-grid.tsx
Outdated
{variant === 'shadow' && <ShadowPreview name={name} value={value} />} | ||
{variant === 'default' && <DefaultPreview name={name} value={value} />} | ||
<Box sx={{fontFamily: 'mono', fontSize: 1, mt: 2}}>{name}</Box> | ||
<Box sx={{fontFamily: 'mono', fontSize: 0, color: 'text.gray'}}>{`--${getFullName( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me 👍
|
||
Use for Sponsors-related interfaces. | ||
|
||
<SwatchGrid names={Object.keys(flatten(colors.light)).filter(key => key.split('.')[0] === 'sponsors')} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem
The Primer Primitives documentation site does not include clear documentation for our functional color system.
Solution
This PR adds documentation for the new functional color system (added in this PR)
Before
After
CleanShot.2021-09-03.at.13.40.06.mp4