-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish new functional color system #224
Merged
Merged
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
617ff0b
Copy colors_v2 to colors directory
colebemis 91ae0c2
Update light deprecated variables
colebemis de12edd
Add dark deprecated variables
colebemis 7e6a502
Rename "product" variables to "app" variables
colebemis a189e7a
Deprecate auto variables
colebemis 5161cff
Update deprecations.json
colebemis e029a5d
Fix deprecations
colebemis 9c6843d
Update import
colebemis 7ab2ab1
Remove var count action
colebemis ed8c340
Merge remote-tracking branch 'origin/main' into publish-v2
colebemis 93cf5b8
Update deprecations.json
colebemis 2ce345e
Pull changes from main
colebemis c14b0e9
Create calm-news-double.md
colebemis c77caf4
Create six-waves-cross.md
colebemis ddbcc0c
Create cyan-rivers-mate.md
colebemis dc9ec48
Update calm-news-double.md
colebemis f8f658c
Update six-waves-cross.md
colebemis 98f41b7
Merge remote-tracking branch 'origin/main' into publish-v2
colebemis e3cd86e
Update deprecated variables
colebemis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@primer/primitives": minor | ||
--- | ||
|
||
Add new functional color variables. See [primer.style/primitives/colors](https://primer.style/primitives/colors) for details about the new color system. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@primer/primitives": minor | ||
--- | ||
|
||
Introduce a Dark High Contrast theme. | ||
|
||
**Note:** The Dark High Contrast theme will only work with the new [functional color variables](https://primer.style/primitives/colors#functional-variables) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@primer/primitives": minor | ||
--- | ||
|
||
Deprecate variables from the old color system. See [primer.style/primitives/colors#deprecated-variables](https://primer.style/primitives/colors#deprecated-variables) for the complete list of deprecated variables. |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variables in
colors/
andcolors_v2/
are the same now so this action won't give us useful information anymore.