-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete data/colors_v2
directory
#233
Conversation
🦋 Changeset detectedLatest commit: f51808b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primitives/5993eMh5mULDooHtAxTmM8hoR6d1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not merge until dotcom no longer uses variables from the
colors_v2
directory
Aren't the V2 variables still available as part of deprecated_light.ts
and get output to the :root {}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
colors-v2 bundle gone from dotcom
@simurai Yup. That's what allows us to remove the |
Hmm.. I got confused about...
but I think it's more about the CSS bundles importing from |
🛑 Do not merge until dotcom no longer uses variables from thecolors_v2
directory https://github.com/github/github/pull/192017Now that we've officially published the v2 functional color system, we can remove the experimental
colors_v2
directory that we were using to test the v2 functional color system in github.com.