Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete data/colors_v2 directory #233

Merged
merged 4 commits into from
Sep 7, 2021
Merged

Delete data/colors_v2 directory #233

merged 4 commits into from
Sep 7, 2021

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented Sep 3, 2021

🛑 Do not merge until dotcom no longer uses variables from the colors_v2 directory https://github.com/github/github/pull/192017

Now that we've officially published the v2 functional color system, we can remove the experimental colors_v2 directory that we were using to test the v2 functional color system in github.com.

Before After
Untitled-2021-07-21-1443(4) Untitled-2021-07-21-1443(5)

@colebemis colebemis requested a review from a team as a code owner September 3, 2021 22:46
@colebemis colebemis requested review from simurai and removed request for a team September 3, 2021 22:46
@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2021

🦋 Changeset detected

Latest commit: f51808b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/5993eMh5mULDooHtAxTmM8hoR6d1
✅ Preview: https://primitives-git-colebemis-patch-3-primer.vercel.app

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge until dotcom no longer uses variables from the colors_v2 directory

Aren't the V2 variables still available as part of deprecated_light.ts and get output to the :root {}?

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colors-v2 bundle gone from dotcom :shipit:

@colebemis
Copy link
Contributor Author

Aren't the V2 variables still available as part of deprecated_light.ts and get output to the :root {}?

@simurai Yup. That's what allows us to remove the colors_v2 directory without breaking anything

@colebemis colebemis merged commit 647cf69 into main Sep 7, 2021
@colebemis colebemis deleted the colebemis-patch-3 branch September 7, 2021 21:20
@primer-css primer-css mentioned this pull request Sep 7, 2021
@simurai
Copy link
Contributor

simurai commented Sep 8, 2021

Yup. That's what allows us to remove the colors_v2 directory without breaking anything

Hmm.. I got confused about...

Do not merge until dotcom no longer uses variables from the colors_v2 directory

but I think it's more about the CSS bundles importing from colors_v2 directory and less about the v1 variables still being available. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants