Use new Primer color names #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like Github recently updated its colors (primer/primitives#224) and removed some of the variables this extension was using. I updated references to these colors and went through each of the appearance settings and verified this extension's styles matches Github's settings Light Default
Light High Contrast
Dark Default
Dark High Contrast
Dark Dimmed
|
ryanrishi
changed the title
|
Hi @berzniz, happy new year! Any thoughts on this change? |
|
Wow @ryanrishi - you've done some amazing job here! All themes looks great now 💯
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this was applying the dark theme if
[data-color-mode=dark]is in an ancestor tag (based on this Hacker News post). This changeset uses a media query to apply a dark theme instead of relying on an attribute in an ancestor tag.With this change, using local extension build:
Relates to #60, Fixes #182